From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754973AbbJHScp (ORCPT ); Thu, 8 Oct 2015 14:32:45 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:48630 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754662AbbJHScn (ORCPT ); Thu, 8 Oct 2015 14:32:43 -0400 Date: Thu, 8 Oct 2015 19:32:34 +0100 From: Russell King - ARM Linux To: Ulf Hansson Cc: Ludovic Desroches , linux-mmc , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Nicolas Ferre , Alexandre Belloni Subject: Re: [PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST Message-ID: <20151008183234.GK32532@n2100.arm.linux.org.uk> References: <1442477780-30994-1-git-send-email-ludovic.desroches@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2015 at 08:01:23PM +0200, Ulf Hansson wrote: > +Russell > > On 17 September 2015 at 10:16, Ludovic Desroches > wrote: > > The Atmel sdhci device needs a new quirk. sdhci_set_clock set the Clock > > Control Register to 0 before computing the new value and writing it. > > It disables the internal clock which causes a reset mecanism. If we > > write the new value before this reset mecanism is done, it will prevent > > the stabilisation of the internal clock, so a delay is needed. This > > delay is about 2-3 cycles of the base clock. To be safe, a 1 ms delay is > > used. > > > > Signed-off-by: Ludovic Desroches > > --- > > Hi Ulf, > > > > Can you take these patches as fixes? I thought it was better to introduce a > > quirk instead of duplicating a part of the sdhci_set_clock function to > > implement my own set_clock function. > > Hi Ludovic, > > Sorry for the delay! > > I have been thinking of how to address patches for sdhci that adds > more quirks/callbacks. To be honest, I am fed up with such patches as > I think it keeps the development of sdhci going in the wrong > direction. > > Instead, I have been hoping for someone to have stab into turning > sdhci into a library as Russell King pointed out several times as > well. > > Now, as my response too you had a big delay for these patches and > because it's a fix intended for the rc, I am going to apply patch1 and > patch2 anyway. Although, you and everybody else that contributes to > the sdhci development, please consider this as the *last* time for > adding quirks/callbacks, unless you have *very good* reasons. +1 on all of that. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.