From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758118AbbJHSe6 (ORCPT ); Thu, 8 Oct 2015 14:34:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45593 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752841AbbJHSe5 (ORCPT ); Thu, 8 Oct 2015 14:34:57 -0400 Date: Thu, 8 Oct 2015 20:34:54 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: linux-kernel@vger.kernel.org Cc: kvm@vger.kernel.org, Paolo Bonzini , Steve Rutherford Subject: Re: [PATCH] KVM: x86: don't notify userspace IOAPIC on edge EOI Message-ID: <20151008183453.GD4508@potion.brq.redhat.com> References: <1444329000-8723-1-git-send-email-rkrcmar@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1444329000-8723-1-git-send-email-rkrcmar@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-10-08 20:30+0200, Radim Krčmář: > On real hardware, edge-triggered interrupts don't set a bit in TMR, > which means that IOAPIC isn't notified on EOI. Do the same here. > > Staying in guest/kernel mode after edge EOI is what we want for most > devices. If some bugs could be nicely worked around with edge EOI > notifications, we should invest in a better interface. > > Signed-off-by: Radim Krčmář > --- > Completely untested. > > diff --git a/arch/x86/kvm/irq_comm.c b/arch/x86/kvm/irq_comm.c > @@ -389,13 +389,15 @@ void kvm_scan_ioapic_routes(struct kvm_vcpu *vcpu, u64 *eoi_exit_bitmap) > for (i = 0; i < nr_ioapic_pins; ++i) { > hlist_for_each_entry(entry, &table->map[i], link) { > u32 dest_id, dest_mode; > + bool level; > > if (entry->type != KVM_IRQ_ROUTING_MSI) > continue; > dest_id = (entry->msi.address_lo >> 12) & 0xff; > dest_mode = (entry->msi.address_lo >> 2) & 0x1; > - if (kvm_apic_match_dest(vcpu, NULL, 0, dest_id, > - dest_mode)) { > + level = entry->msi.data & MSI_DATA_TRIGGER_LEVEL; > + if (level && kvm_apic_match_dest(vcpu, NULL, 0, Describing that result is an overkill -- I'll send v2 if the idea is accepted.