From: "Luis R. Rodriguez" <mcgrof@suse.com>
To: Josh Boyer <jwboyer@fedoraproject.org>
Cc: "Luis R. Rodriguez" <mcgrof@do-not-panic.com>,
Greg KH <gregkh@linuxfoundation.org>,
Ming Lei <ming.lei@canonical.com>,
Jonathan Corbet <corbet@lwn.net>,
"Linux-Kernel@Vger. Kernel. Org" <linux-kernel@vger.kernel.org>,
linux-doc@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
David Howells <dhowells@redhat.com>,
Seth Forshee <seth.forshee@canonical.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Michal Marek <mmarek@suse.cz>,
Matthew Garrett <mjg59@srcf.ucam.org>,
kyle@kernel.org,
linux-security-module <linux-security-module@vger.kernel.org>,
keyrings@linux-nfs.org, Tom Gundersen <teg@jklm.no>
Subject: Re: [PATCH v2 5/5] firmware: add an extensible system data helpers
Date: Fri, 9 Oct 2015 01:03:53 +0200 [thread overview]
Message-ID: <20151008230353.GM14464@wotan.suse.de> (raw)
In-Reply-To: <CA+5PVA6z81xawNp0_Fw6Ah40CN4yx4ikPNKkKZMTKf3GtdyTbQ@mail.gmail.com>
On Thu, Oct 08, 2015 at 01:59:11PM -0400, Josh Boyer wrote:
> On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez
> > +static inline int desc_sync_found_call_cb(const struct sysdata_file_desc *desc,
> > + const struct sysdata_file *sysdata)
> > +{
> > + BUG_ON(desc->sync_reqs.mode != SYNCDATA_SYNC);
>
> ngh... Why do these inline functions all have BUG_ONs in them? If it
> is to catch a programming error, why can't you just return EINVAL like
> you do in the async function case? (Even that WARN_ON seems
> excessive).
Sure, I've replaced the pesky BUG_ON() with returning -EINVAL's.
Let me know if there is anything else.
Luis
prev parent reply other threads:[~2015-10-08 23:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-01 17:44 [PATCH v2 0/5] firmware_class: extensible firmware API Luis R. Rodriguez
2015-10-01 17:44 ` [PATCH v2 1/5] firmware: generalize "firmware" as "system data" helpers Luis R. Rodriguez
2015-10-01 17:44 ` [PATCH v2 2/5] firmware: move completing fw into a helper Luis R. Rodriguez
2015-10-01 17:44 ` [PATCH v2 3/5] firmware: fold successful fw read early Luis R. Rodriguez
2015-10-01 17:44 ` [PATCH v2 4/5] firmware: generalize reading file contents as a helper Luis R. Rodriguez
2015-10-08 17:36 ` Josh Boyer
2015-10-08 22:54 ` Luis R. Rodriguez
2015-10-09 12:46 ` Josh Boyer
2015-10-09 15:46 ` Luis R. Rodriguez
2015-10-01 17:44 ` [PATCH v2 5/5] firmware: add an extensible system data helpers Luis R. Rodriguez
2015-10-08 17:59 ` Josh Boyer
2015-10-08 23:03 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008230353.GM14464@wotan.suse.de \
--to=mcgrof@suse.com \
--cc=corbet@lwn.net \
--cc=dhowells@redhat.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=jwboyer@fedoraproject.org \
--cc=keyrings@linux-nfs.org \
--cc=kyle@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mcgrof@do-not-panic.com \
--cc=ming.lei@canonical.com \
--cc=mjg59@srcf.ucam.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=seth.forshee@canonical.com \
--cc=teg@jklm.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®