From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756161AbbJHXHX (ORCPT ); Thu, 8 Oct 2015 19:07:23 -0400 Received: from mga11.intel.com ([192.55.52.93]:32599 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753926AbbJHXHV (ORCPT ); Thu, 8 Oct 2015 19:07:21 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,656,1437462000"; d="scan'208";a="660691117" Date: Thu, 8 Oct 2015 17:07:20 -0600 From: Ross Zwisler To: Ross Zwisler Cc: linux-kernel@vger.kernel.org, "J. Bruce Fields" , Jeff Layton , linux-fsdevel@vger.kernel.org, Miklos Szeredi , David Howells Subject: Re: [PATCH] vfs: remove stale comment in inode_operations Message-ID: <20151008230720.GA19399@linux.intel.com> Mail-Followup-To: Ross Zwisler , linux-kernel@vger.kernel.org, "J. Bruce Fields" , Jeff Layton , linux-fsdevel@vger.kernel.org, Miklos Szeredi , David Howells References: <1441753160-26476-1-git-send-email-ross.zwisler@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1441753160-26476-1-git-send-email-ross.zwisler@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 08, 2015 at 04:59:20PM -0600, Ross Zwisler wrote: > The big warning comment that is currently at the end of struct > inode_operations was added as part of this commit: > > 4aa7c6346be3 ("vfs: add i_op->dentry_open()") > > It was added to warn people not to use the newly added 'dentry_open' > function pointer. > > This function pointer was removed as part of this commit: > > 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and > f_inode to the underlay") > > The comment was left behind and now refers to nothing, so remove it. > > Signed-off-by: Ross Zwisler > --- > include/linux/fs.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/fs.h b/include/linux/fs.h > index b2f9b9c..b3ff479 100644 > --- a/include/linux/fs.h > +++ b/include/linux/fs.h > @@ -1679,8 +1679,6 @@ struct inode_operations { > umode_t create_mode, int *opened); > int (*tmpfile) (struct inode *, struct dentry *, umode_t); > int (*set_acl)(struct inode *, struct posix_acl *, int); > - > - /* WARNING: probably going away soon, do not use! */ > } ____cacheline_aligned; > > ssize_t rw_copy_check_uvector(int type, const struct iovec __user * uvector, Ping?