Re: [RFC/PATCH 15/38] perf tools: Introduce machine__find*_thread_by_time()

[Namhyung Kim <namhyung@kernel.org>]

On Thu, Oct 08, 2015 at 02:20:11PM +0200, Jiri Olsa wrote:
> On Fri, Oct 02, 2015 at 02:18:56PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> > diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c
> > index 674792e8fa2f..ad7c2a00bff8 100644
> > --- a/tools/perf/util/thread.c
> > +++ b/tools/perf/util/thread.c
> > @@ -160,6 +160,9 @@ int __thread__set_comm(struct thread *thread, const char *str, u64 timestamp,
> >  
> >  	/* Override the default :tid entry */
> >  	if (!thread->comm_set) {
> > +		if (!thread->start_time)
> > +			thread->start_time = timestamp;
> > +
> >  		err = comm__override(curr, str, timestamp, exec);
> >  		if (err)
> >  			return err;
> > @@ -266,6 +269,7 @@ int thread__fork(struct thread *thread, struct thread *parent, u64 timestamp)
> >  	}
> >  
> >  	thread->ppid = parent->tid;
> > +	thread->start_time = timestamp;
> >  	return thread__clone_map_groups(thread, parent);
> >  }
> >  
> > diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
> > index b8f794d97b75..97026a9660ec 100644
> > --- a/tools/perf/util/thread.h
> > +++ b/tools/perf/util/thread.h
> > @@ -28,6 +28,7 @@ struct thread {
> >  	bool			dead; /* thread is in dead_threads list */
> >  	struct list_head	comm_list;
> >  	u64			db_id;
> > +	u64			start_time;
> 
> introducing start_time could be in separate patch
> would ease up the review a bit

Will split.

Thanks,
Namhyung