From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org,
ulf.hansson@linaro.org, sebastian.hesselbarth@gmail.com,
andrew@lunn.ch, jason@lakedaemon.net,
gregory.clement@free-electrons.com, nadavh@marvell.com,
alior@marvell.com, tawfik@marvell.com, jaz@semihalf.com
Subject: Re: [PATCH v2 3/5] ARM: mvebu: set SW polling as SDHCI card detection on A388-GP
Date: Fri, 9 Oct 2015 09:52:04 +0200 [thread overview]
Message-ID: <20151009095204.41010dd9@free-electrons.com> (raw)
In-Reply-To: <1444352635-21965-4-git-send-email-mw@semihalf.com>
Dear Marcin Wojtas,
On Fri, 9 Oct 2015 03:03:53 +0200, Marcin Wojtas wrote:
> The newest revisions of A388-GP (v1.5 and higher) support only
> DAT3-based card detection. Revisions < v1.5 based on GPIO detection
> via I2C expander, but this solution is supposed to be deprecated on
> new boards. In order to satisfy all type of hardware this commit
> changes card detection to use software polling mechanism.
>
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Can we add a comment on the DT that explains why SW polling is used,
and which other mechanism can be used depending on the board revision?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-10-09 7:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-09 1:03 [PATCH v2 0/5] Armada 38x SDHCI driver improvements Marcin Wojtas
2015-10-09 1:03 ` [PATCH v2 1/5] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Marcin Wojtas
2015-10-09 1:03 ` [PATCH v2 2/5] mmc: sdhci-pxav3: enable usage of DAT3 pin as HW card detect Marcin Wojtas
2015-10-09 12:13 ` Jisheng Zhang
2015-10-09 13:46 ` Russell King - ARM Linux
2015-10-09 14:45 ` Marcin Wojtas
2015-10-10 7:05 ` Jisheng Zhang
2015-10-10 12:13 ` Marcin Wojtas
2015-10-12 2:52 ` Jisheng Zhang
2015-10-09 1:03 ` [PATCH v2 3/5] ARM: mvebu: set SW polling as SDHCI card detection on A388-GP Marcin Wojtas
2015-10-09 7:52 ` Thomas Petazzoni [this message]
2015-10-09 10:16 ` Marcin Wojtas
2015-10-09 13:46 ` Andrew Lunn
2015-10-09 1:03 ` [PATCH v2 4/5] mmc: sdhci: add init_card callback to sdhci Marcin Wojtas
2015-10-09 1:03 ` [PATCH v2 5/5] mmc: sdhci-pxav3: enable modifying MMC_CARD bit during card initialization Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009095204.41010dd9@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=jaz@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mw@semihalf.com \
--cc=nadavh@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=tawfik@marvell.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome