From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756520AbbJIP3o (ORCPT ); Fri, 9 Oct 2015 11:29:44 -0400 Received: from mga03.intel.com ([134.134.136.65]:46286 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650AbbJIP3m convert rfc822-to-8bit (ORCPT ); Fri, 9 Oct 2015 11:29:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,658,1437462000"; d="scan'208";a="661133184" Date: Fri, 9 Oct 2015 16:29:27 +0100 From: Vinod Koul To: Maxime Ripard Cc: Nicolas Ferre , Alexandre Belloni , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Ludovic Desroches , Cyrille Pitchen Subject: Re: [PATCH 1/2] dmaengine: hdmac: factorise memset descriptor allocation Message-ID: <20151009152926.GD3609@vkoul-mobl.iind.intel.com> References: <1443711158-18495-1-git-send-email-maxime.ripard@free-electrons.com> <1443711158-18495-2-git-send-email-maxime.ripard@free-electrons.com> <20151007135412.GB3320@vkoul-mobl.iind.intel.com> <20151007173317.GG2278@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20151007173317.GG2278@lukather> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 07, 2015 at 06:33:17PM +0100, Maxime Ripard wrote: > > This is fine, but this is driver limitation. We should really split the > > txn to multiple descriptors here.. > > Both these things are actually just copy from the previous code. > > I can probably fix the first style issue in this patch, but splitting > the memset descriptors should go in a separate patch. That sounds fine -- ~Vinod