From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932576AbbJIPuo (ORCPT ); Fri, 9 Oct 2015 11:50:44 -0400 Received: from mga09.intel.com ([134.134.136.24]:14260 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756940AbbJIPum (ORCPT ); Fri, 9 Oct 2015 11:50:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,658,1437462000"; d="scan'208";a="823074654" Date: Fri, 9 Oct 2015 16:50:39 +0100 From: Vinod Koul To: Colin King Cc: Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] dmaengine: zxdma: fix memset that is currently doing nothing Message-ID: <20151009155038.GF3609@vkoul-mobl.iind.intel.com> References: <1444323694-3189-1-git-send-email-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444323694-3189-1-git-send-email-colin.king@canonical.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2015 at 06:01:34PM +0100, Colin King wrote: > From: Colin Ian King > > The size and value arguments are swapped in the call to memset > effectively making it a no-op because of the zero size. Swap > these arguments around to do the memset correctly. Sorry you are late! You should always sync to target tree before generating a patch commit 1a492ac2b87b05c8a175478e79d3c74511c74921 Author: Vinod Koul Date: Thu Oct 1 07:11:48 2015 +0530 dmaengine: zxdma: fix memset call Fix the call to memset in this driver [linux-4.2-next-20150911/drivers/dma/zx296702_dma.c:444]: (warning) memset() called to fill 0 bytes of 'ds'. Reported-by: David Binderman Signed-off-by: Vinod Koul -- ~Vinod