From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753568AbbJIXU3 (ORCPT ); Fri, 9 Oct 2015 19:20:29 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:52341 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbbJIXU1 (ORCPT ); Fri, 9 Oct 2015 19:20:27 -0400 Date: Sat, 10 Oct 2015 00:20:15 +0100 From: Russell King - ARM Linux To: Mans Rullgard Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-cris-kernel@axis.com, linux-mips@linux-mips.org, linux-xtensa@linux-xtensa.org, kernel@stlinux.com, linux-rpi-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] sched_clock: add data pointer argument to read callback Message-ID: <20151009232015.GC32536@n2100.arm.linux.org.uk> References: <1444427858-576-1-git-send-email-mans@mansr.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444427858-576-1-git-send-email-mans@mansr.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 09, 2015 at 10:57:35PM +0100, Mans Rullgard wrote: > This passes a data pointer specified in the sched_clock_register() > call to the read callback allowing simpler implementations thereof. > > In this patch, existing uses of this interface are simply updated > with a null pointer. This is a bad description. It tells us what the patch is doing, (which we can see by reading the patch) but not _why_. Please include information on why the change is necessary - describe what you are trying to achieve. I generally don't accept patches what add new stuff to the kernel with no users of that new stuff - that's called experience, experience of people who submit stuff like that, and then vanish leaving their junk in the kernel without any users. Please ensure that this gets a user very quickly, or better still, submit this patch as part of a series which makes use of it. Also, copying soo many people is guaranteed to be silently dropped by mailing lists. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.