From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751801AbbJKLkM (ORCPT ); Sun, 11 Oct 2015 07:40:12 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:56956 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751498AbbJKLkK (ORCPT ); Sun, 11 Oct 2015 07:40:10 -0400 Date: Sun, 11 Oct 2015 04:55:57 -0700 (PDT) Message-Id: <20151011.045557.2164838188213641141.davem@davemloft.net> To: jbaron@akamai.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, minipli@googlemail.com, normalperson@yhbt.net, eric.dumazet@gmail.com, rweikusat@mobileactivedefense.com, viro@zeniv.linux.org.uk, davidel@xmailserver.org, dave@stgolabs.net, olivier@mauras.ch, pageexec@freemail.hu, torvalds@linux-foundation.org, peterz@infradead.org, joe@perches.com Subject: Re: [PATCH v4 0/3] net: unix: fix use-after-free From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-7 X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 11 Oct 2015 04:40:09 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t9BBeJdh012956 From: Jason Baron Date: Fri, 9 Oct 2015 00:15:59 -0400 > These patches are against mainline, I can re-base to net-next, please > let me know. > > They have been tested against: https://lkml.org/lkml/2015/9/13/195, > which causes the use-after-free quite quickly and here: > https://lkml.org/lkml/2015/10/2/693. I'd like to understand how patches that don't even compile can be "tested"? net/unix/af_unix.c: In function unix_dgram_writable: net/unix/af_unix.c:2480:3: error: other_full undeclared (first use in this function) net/unix/af_unix.c:2480:3: note: each undeclared identifier is reported only once for each function it appears in Could you explain how that works, I'm having a hard time understanding this? Also please address Hannes's feedback, thanks. {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I