From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751354AbbJKAjA (ORCPT ); Sat, 10 Oct 2015 20:39:00 -0400 Received: from mga09.intel.com ([134.134.136.24]:13888 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751039AbbJKAi7 (ORCPT ); Sat, 10 Oct 2015 20:38:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.17,665,1437462000"; d="scan'208";a="824057362" Date: Sun, 11 Oct 2015 08:37:53 +0800 From: kbuild test robot To: Punit Vara Cc: kbuild-all@01.org, Larry.Finger@lwfinger.net, dogukan.ergun@gmail.com, florian.c.schilhabel@googlemail.com, Punit Vara , stillcompiling@gmail.com, gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Julia.Lawall@lip6.fr, sudipm.mukherjee@gmail.com, dan.carpenter@oracle.com Subject: Re: [PATCH 2/4] Staging: rtl8712: Use ether_addr_equal() over memcmp() Message-ID: <201510110819.TbhmLPRg%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444496322-3648-3-git-send-email-punitvara@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Punit, [auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore] reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__CHECK_ENDIAN__ sparse warnings: (new ones prefixed by >>) drivers/staging/rtl8712/rtl871x_ioctl_linux.c:227:15: sparse: cast to restricted __le16 >> drivers/staging/rtl8712/rtl871x_ioctl_linux.c:2010:54: sparse: incorrect type in argument 2 (different base types) drivers/staging/rtl8712/rtl871x_ioctl_linux.c:2010:54: expected unsigned char const [usertype] *addr2 drivers/staging/rtl8712/rtl871x_ioctl_linux.c:2010:54: got struct wlan_bssid_ex network drivers/staging/rtl8712/rtl871x_ioctl_linux.c: In function 'r871x_get_ap_info': drivers/staging/rtl8712/rtl871x_ioctl_linux.c:2010:32: error: incompatible type for argument 2 of 'ether_addr_equal' if (!ether_addr_equal(bssid, pnetwork->network)) { ^ In file included from drivers/staging/rtl8712/osdep_service.h:39:0, from drivers/staging/rtl8712/rtl871x_ioctl_linux.c:32: include/linux/etherdevice.h:310:20: note: expected 'const u8 * {aka const unsigned char *}' but argument is of type 'struct wlan_bssid_ex' static inline bool ether_addr_equal(const u8 *addr1, const u8 *addr2) ^ vim +2010 drivers/staging/rtl8712/rtl871x_ioctl_linux.c 1994 return -EINVAL; 1995 spin_lock_irqsave(&(pmlmepriv->scanned_queue.lock), irqL); 1996 phead = &queue->queue; 1997 plist = phead->next; 1998 while (1) { 1999 if (end_of_queue_search(phead, plist) == true) 2000 break; 2001 pnetwork = LIST_CONTAINOR(plist, struct wlan_network, list); 2002 if (hwaddr_aton_i(data, bssid)) { 2003 netdev_info(dev, "r8712u: Invalid BSSID '%s'.\n", 2004 (u8 *)data); 2005 spin_unlock_irqrestore(&(pmlmepriv->scanned_queue.lock), 2006 irqL); 2007 return -EINVAL; 2008 } 2009 netdev_info(dev, "r8712u: BSSID:%pM\n", bssid); > 2010 if (!ether_addr_equal(bssid, pnetwork->network)) { 2011 /* BSSID match, then check if supporting wpa/wpa2 */ 2012 pbuf = r8712_get_wpa_ie(&pnetwork->network.IEs[12], 2013 &wpa_ielen, pnetwork->network.IELength-12); 2014 if (pbuf && (wpa_ielen > 0)) { 2015 pdata->flags = 1; 2016 break; 2017 } 2018 pbuf = r8712_get_wpa2_ie(&pnetwork->network.IEs[12], --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation