Re: [PATCH] thinkpad_acpi: Add TP_HKEY_EV_SCREEN_FLIP (0x60c0) for Lenovo ThinkPad Yoga 12

[Henrique de Moraes Holschuh <hmh@hmh.eng.br>]

On Sat, 10 Oct 2015, Darren Hart wrote:
> On Sat, Oct 10, 2015 at 06:40:34PM -0300, Henrique de Moraes Holschuh wrote:
> > On Sat, 10 Oct 2015, Darren Hart wrote:
> > > On Sat, Oct 10, 2015 at 11:41:47AM -0700, Darren Hart wrote:
> > > > From: Darren Hart <dvhart@infradead.org>
> > > > 
> > > > thinkpad_acpi reports "unhandled HKEY event 0x60c0" when switching
> > > > between laptop and tent/tablet mode on the ThinkPad Yoga 12. This key is
> > > > reported by atkbd serio0 as e058 and e059.
> > > > 
> > > > Add TP_HKEY_EV_SCREEN_FLIP to the list of ignored events and silence the
> > > > warning.
> > > > 
> > > > Cleanup whitespace on preceeding line for TP_HKEY_EV_KEY_FN_ESC.
> > > > 
> > > > Signed-off-by: Darren Hart <dvhart@infradead.org>
> > > > Cc: Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>
> > > > Cc: ibm-acpi-devel@lists.sourceforge.net
> > 
> > Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> 
> Thanks Henrique,
> 
> Now, as I'm digging into this I'm finding maybe there is more to this. Should I
> be attempting to tie this in to the tablet switch mechanism for the older x61t?

I think so, provided that you can read the current mode from somewhere.  And
it is likelt to be exported by the EC somehow, since atkbd gets two separate
keycodes...

> Or is this something we now want to strictly hand off to a userspace helper via
> the atkbd event?

It depends on the existence of said userspace helper, I suppose.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh