From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbbJLMWe (ORCPT ); Mon, 12 Oct 2015 08:22:34 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:36232 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbbJLMWd (ORCPT ); Mon, 12 Oct 2015 08:22:33 -0400 Date: Mon, 12 Oct 2015 05:38:14 -0700 (PDT) Message-Id: <20151012.053814.1870650163021801761.davem@davemloft.net> To: geliangtang@163.com Cc: pcnet32@frontier.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] pcnet32: fix a logic error with pci_set_dma_mask From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 12 Oct 2015 05:22:32 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Geliang Tang Date: Fri, 9 Oct 2015 03:45:39 -0700 > pcnet32 can't work on my machine recently. It says "architecture > does not support 32bit PCI busmaster DMA". There is a logic error > in it: pci_set_dma_mask() return 0 means return successfully. > > Signed-off-by: Geliang Tang This driver doesn't call pci_set_dma_mask() in any of my tree(s).