From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767AbbJLGx3 (ORCPT ); Mon, 12 Oct 2015 02:53:29 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59970 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751711AbbJLGx0 (ORCPT ); Mon, 12 Oct 2015 02:53:26 -0400 Date: Mon, 12 Oct 2015 08:53:23 +0200 From: Alexandre Belloni To: Wenyou Yang Cc: Alessandro Zummo , Nicolas Ferre , Ludovic Desroches , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Message-ID: <20151012065323.GA3558@piout.net> References: <1444612677-26178-1-git-send-email-wenyou.yang@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444612677-26178-1-git-send-email-wenyou.yang@atmel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wenyou, On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote : > This patch is to clear the RTC alarm status flag prior to suspending > to avoid the erroneous wake-up activity. > Is this a new issue appearing with the sama5d2 or was it present from the beginning? > Signed-off-by: Wenyou Yang > --- > > drivers/rtc/rtc-at91rm9200.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c > index cb62e21..b60fd47 100644 > --- a/drivers/rtc/rtc-at91rm9200.c > +++ b/drivers/rtc/rtc-at91rm9200.c > @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev) > /* this IRQ is shared with DBGU and other hardware which isn't > * necessarily doing PM like we are... > */ > + at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM); > + > at91_rtc_imr = at91_rtc_read_imr() > & (AT91_RTC_ALARM|AT91_RTC_SECEV); > if (at91_rtc_imr) { > -- > 1.7.9.5 > -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com