From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbbJLIis (ORCPT ); Mon, 12 Oct 2015 04:38:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58860 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751157AbbJLIiq (ORCPT ); Mon, 12 Oct 2015 04:38:46 -0400 Date: Mon, 12 Oct 2015 10:38:42 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Rabin Vincent , Jiri Olsa , Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] perf: unwind: fix unw_word_t pointer casts Message-ID: <20151012083842.GB30819@krava.redhat.com> References: <1443379079-29133-1-git-send-email-rabin.vincent@axis.com> <20151010154940.GA26352@debian> <20151010233408.GP14409@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151010233408.GP14409@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 10, 2015 at 08:34:08PM -0300, Arnaldo Carvalho de Melo wrote: > Em Sat, Oct 10, 2015 at 05:49:40PM +0200, Rabin Vincent escreveu: > > Hi Arnaldo, > > > > Do you have any comments on this patch set? > > I looked at the patches now, all seem fine from a quick look. > > The last patch is interesting, and a more general way of installing what > is required for a full build using the native method for a distro, i.e. > using yum/dnf/apt/etc would come in handy as well, so that it doesn't > look like we recommend this fetch-the-sources-and-build-it method, but > sure, that can come later, when someone steps up to that work. > > Since this touches the build system and libunwind, areas that Jiri > wrote/knows better, I'd like to get his ack, Jiri? Acked-by: Jiri Olsa thanks, jirka