From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751896AbbJLLY3 (ORCPT ); Mon, 12 Oct 2015 07:24:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51108 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751677AbbJLLY1 (ORCPT ); Mon, 12 Oct 2015 07:24:27 -0400 Date: Mon, 12 Oct 2015 13:24:23 +0200 From: Jiri Olsa To: Rabin Vincent Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, Rabin Vincent , Namhyung Kim Subject: Re: [PATCH 2/5] perf: unwind: pass symbol source to libunwind Message-ID: <20151012112423.GA20170@krava.brq.redhat.com> References: <1443379079-29133-1-git-send-email-rabin.vincent@axis.com> <1443379079-29133-2-git-send-email-rabin.vincent@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443379079-29133-2-git-send-email-rabin.vincent@axis.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2015 at 08:37:56PM +0200, Rabin Vincent wrote: > Even if --symfs is used to point to the debug binaries, we send in the > non-debug filenames to libunwind, which leads to libunwind not finding > the debug frame. Fix this. > > Signed-off-by: Rabin Vincent cc-ing Namhyung on this one jirka > --- > tools/perf/util/unwind-libunwind.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/unwind-libunwind.c b/tools/perf/util/unwind-libunwind.c > index ef799dc..b93bf7f 100644 > --- a/tools/perf/util/unwind-libunwind.c > +++ b/tools/perf/util/unwind-libunwind.c > @@ -363,7 +363,7 @@ find_proc_info(unw_addr_space_t as, unw_word_t ip, unw_proc_info_t *pi, > dso__data_put_fd(map->dso); > > memset(&di, 0, sizeof(di)); > - if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->name, > + if (dwarf_find_debug_frame(0, &di, ip, base, map->dso->symsrc_filename, > map->start, map->end)) > return dwarf_search_unwind_table(as, ip, &di, pi, > need_unwind_info, arg); > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/