From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751543AbbJLLfH (ORCPT ); Mon, 12 Oct 2015 07:35:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53428 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751286AbbJLLfG (ORCPT ); Mon, 12 Oct 2015 07:35:06 -0400 Date: Mon, 12 Oct 2015 13:35:02 +0200 From: Jiri Olsa To: Rabin Vincent Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, Rabin Vincent Subject: Re: [PATCH 4/5] tools: build: fix libiberty feature detection Message-ID: <20151012113502.GC20170@krava.brq.redhat.com> References: <1443379079-29133-1-git-send-email-rabin.vincent@axis.com> <1443379079-29133-4-git-send-email-rabin.vincent@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1443379079-29133-4-git-send-email-rabin.vincent@axis.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Sep 27, 2015 at 08:37:58PM +0200, Rabin Vincent wrote: > Pass CFLAGS and LDFLAGS to the libiberty compile line to make the > detection work when using a cross compiler. > > Otherwise perf fails to link even though BFD is detected. > > ... libbfd: [ on ] > > LINK perf > libbfd.a(bfd.o): In function `bfd_errmsg': > bfd.c:(.text+0x168): undefined reference to `xstrerror' > bbfd.a(opncls.o): In function `_bfd_new_bfd': > opncls.c:(.text+0xe8): undefined reference to `objalloc_create' We have FEATURE_CHECK_CFLAGS/FEATURE_CHECK_LDFLAGS variables to pass CFLAGS/LDFLAGS to feature detection build Could you also be more specific on what is missing to make the libiberty check compile? thanks, jirka > ... > > Signed-off-by: Rabin Vincent > --- > tools/build/feature/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/build/feature/Makefile b/tools/build/feature/Makefile > index e43a297..cea04ce9 100644 > --- a/tools/build/feature/Makefile > +++ b/tools/build/feature/Makefile > @@ -132,10 +132,10 @@ test-libbfd.bin: > $(BUILD) -DPACKAGE='"perf"' -lbfd -lz -liberty -ldl > > test-liberty.bin: > - $(CC) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' -lbfd -ldl -liberty > + $(CC) $(CFLAGS) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' $(LDFLAGS) -lbfd -ldl -liberty > > test-liberty-z.bin: > - $(CC) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' -lbfd -ldl -liberty -lz > + $(CC) $(CFLAGS) -Wall -Werror -o $(OUTPUT)$@ test-libbfd.c -DPACKAGE='"perf"' $(LDFLAGS) -lbfd -ldl -liberty -lz > > test-cplus-demangle.bin: > $(BUILD) -liberty > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/