From: Dave Martin <Dave.Martin@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
Akhilesh Kumar <akhilesh.k@samsung.com>,
Rohit Thapliyal <r.thapliyal@samsung.com>,
Andreas Schwab <schwab@suse.de>,
Manjeet Pawar <manjeet.p@samsung.com>,
pankaj.m@samsung.com
Subject: Re: [PATCHv2] ARM64:Fix MINSIGSTKSZ and SIGSTKSZ
Date: Mon, 12 Oct 2015 14:53:13 +0100 [thread overview]
Message-ID: <20151012135300.GA26786@e103592.cambridge.arm.com> (raw)
In-Reply-To: <5223992.qv9q1k7gFp@wuerfel>
On Fri, Oct 09, 2015 at 10:41:43AM +0200, Arnd Bergmann wrote:
> On Tuesday 06 October 2015 12:51:24 Arnd Bergmann wrote:
> >
> > I think it makes sense to stick with the traditional definition
> > of MINSIGSTKSZ == "the minimum amount that you will always need,
> > add whatever you require yourself" and SIGSTKSZ == "Should be
> > enough for a couple of function calls". If we want to be conservative
> > in the kernel, using 8192 and 32768, to stay with the x4 ratio
> > that everyone else uses would be my first pick, though I'm not
> > particularly attached to those values.
> >
> >
>
> On second thought, it really seems to late to make up our minds
> about the size now that glibc has already established 5KB as the
> minimum size. If we set it to 8KB/32KB, not just the testcase but
> real applications would start failing when they use the 5KB
> constant from glibc.
I agree for MINSIGSTKSZ. We could still raise SIGSTKSZ if we think
that will be more future-proof (SIGSTKSZ would be less than the magic
4*MINSIGSTKSZ that most arches assume, unless SIGSTKSZ is made >=20KB).
Those might be independent changes. The definition of MINSIGSTKSZ
is definitely broken right now, whereas SIGSTKSZ could be debated,
but isn't actually broken.
Cheers
---Dave
next prev parent reply other threads:[~2015-10-12 13:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 5:35 Manjeet Pawar
2015-10-06 7:49 ` Arnd Bergmann
2015-10-06 9:37 ` Catalin Marinas
2015-10-06 10:31 ` Dave Martin
2015-10-06 10:51 ` Arnd Bergmann
2015-10-06 10:59 ` Andreas Schwab
2015-10-06 11:33 ` Dave Martin
2015-10-06 11:52 ` Andreas Schwab
2015-10-06 12:49 ` Dave Martin
2015-10-06 11:22 ` Dave Martin
2015-10-09 8:41 ` Arnd Bergmann
2015-10-12 13:53 ` Dave Martin [this message]
2015-10-06 10:19 ` Will Deacon
2015-10-09 8:17 Manjeet Pawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012135300.GA26786@e103592.cambridge.arm.com \
--to=dave.martin@arm.com \
--cc=akhilesh.k@samsung.com \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manjeet.p@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=r.thapliyal@samsung.com \
--cc=schwab@suse.de \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®