From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751771AbbJLOHv (ORCPT ); Mon, 12 Oct 2015 10:07:51 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55065 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751657AbbJLOHu (ORCPT ); Mon, 12 Oct 2015 10:07:50 -0400 Date: Mon, 12 Oct 2015 15:07:37 +0100 From: Mark Brown To: Sascha Hauer Cc: linux-kernel@vger.kernel.org, Liam Girdwood , kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org Message-ID: <20151012140737.GB4238@sirena.org.uk> References: <1443621946-8712-1-git-send-email-s.hauer@pengutronix.de> <1443621946-8712-5-git-send-email-s.hauer@pengutronix.de> <20151002173256.GZ12635@sirena.org.uk> <20151012114259.GU7858@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yVhtmJPUSI46BTXb" Content-Disposition: inline In-Reply-To: <20151012114259.GU7858@pengutronix.de> X-Cookie: Oh, so there you are! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2a01:348:6:8808:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 4/6] regulator: core: Propagate voltage changes to supply regulators X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --yVhtmJPUSI46BTXb Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 12, 2015 at 01:42:59PM +0200, Sascha Hauer wrote: > On Fri, Oct 02, 2015 at 06:32:56PM +0100, Mark Brown wrote: > > One change I think we need here is only doing the propagation if either > > the device lacks a set_voltage() operation (in which case it's just a > > switch passing through the parent voltage) > Does the lack of a set_voltage() operation automatically mean it's a > switch passing through the parent voltage? What if the regulator is a > fixed regulator and the output can't be controlled because there is only > one voltage? Sorry, that was a typo for get_voltage(). > Currently we bail out int regulator_set_voltage() when we do not have a > set_voltage() or set_voltage_sel() operation. Instead of propagating the > voltage change up I would keep the current behaviour and implement voltage > propagation for switches when we need it. Then we could also introduce a > REGULATOR_IS_SWITCH flag indicating that this is a switch and not a > fixed voltage regulator. We already have people who'd like it. --yVhtmJPUSI46BTXb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWG76oAAoJECTWi3JdVIfQ0YEH+wYjFA4o622iuE5G+upTiVrh Lx9kL+3JbYBnAdR5YGWYS1+qV3o5HNVn862ZKAJQaxjTKGHr0MdoBSwn+IJZw1uJ /2q9Rd6s+RucpnqMFCgUOYzEwu1PIPA15HX37T5iuBSRZAGSbpE6nUCnCZcGGAv6 YgxNtVdzDHX6eBDNG42zj5Vb8GKogBnkm50xzI9bMQl8VLbtaWIDzipq6rDM01Ui 4alMOwE2enibUFm74Ug6c+jX+ovAvHGjoEW01B5uG2RCU52Nap2Q5Vlfk+w8BMVs 76MAbWj8yS+0/yeV2QjecnUOuN6qR8VJatmMjELYwmw156aws5FxmhZwGLEWreg= =xx7u -----END PGP SIGNATURE----- --yVhtmJPUSI46BTXb--