From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752155AbbJLPPv (ORCPT ); Mon, 12 Oct 2015 11:15:51 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:59366 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752071AbbJLPPt (ORCPT ); Mon, 12 Oct 2015 11:15:49 -0400 Date: Mon, 12 Oct 2015 17:15:42 +0200 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Arnd Bergmann Cc: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, Jiri Slaby , linux-kernel@vger.kernel.org, Nicolas Ferre Subject: Re: [PATCH] serial: fix mctrl helper functions Message-ID: <20151012151542.GY3982@pengutronix.de> References: <5611419.Budt39N01Y@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5611419.Budt39N01Y@wuerfel> User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Arnd, On Mon, Oct 12, 2015 at 05:04:14PM +0200, Arnd Bergmann wrote: > A recent patch to create common helper functions for modem control > lines created empty helper functions in a header file, but accidentally > did not mark them as 'static inline', which causes build errors: > > drivers/tty/serial/mxs-auart.o: In function `mctrl_gpio_enable_ms': > mxs-auart.c:(.text+0x171c): multiple definition of `mctrl_gpio_enable_ms' > drivers/tty/serial/clps711x.o:clps711x.c:(.text+0x768): first defined here > drivers/tty/serial/mxs-auart.o: In function `mctrl_gpio_disable_ms': > mxs-auart.c:(.text+0x1720): multiple definition of `mctrl_gpio_disable_ms' > drivers/tty/serial/clps711x.o:clps711x.c:(.text+0x76c): first defined here > > This adds the missing annotation, so the functions do not get placed > in each object file. > > Signed-off-by: Arnd Bergmann > Fixes: ce59e48fdbad ("serial: mctrl_gpio: implement interrupt handling") Sounds and looks right. Thanks. Acked-by: Uwe Kleine-König -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |