From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752558AbbJLPZ6 (ORCPT ); Mon, 12 Oct 2015 11:25:58 -0400 Received: from mail-yk0-f170.google.com ([209.85.160.170]:32805 "EHLO mail-yk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752499AbbJLPZ4 (ORCPT ); Mon, 12 Oct 2015 11:25:56 -0400 Date: Mon, 12 Oct 2015 11:25:52 -0400 From: Tejun Heo To: Aleksa Sarai Cc: lizefan@huawei.com, hannes@cmpxchg.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH 14/14] cgroup: add cgroup_subsys->free() method and use it to fix pids controller Message-ID: <20151012152552.GA23399@mtj.duckdns.org> References: <1444447781-16182-1-git-send-email-tj@kernel.org> <1444570210-15640-4-git-send-email-tj@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Oct 12, 2015 at 09:29:14PM +1100, Aleksa Sarai wrote: > > pids controller is completely broken in that it uncharges when a task > > exits allowing zombies to escape resource control. With the recent > > updates, cgroup core now maintains cgroup association till task free > > and pids controller can be fixed by uncharging on free instead of > > exit. > > Looks good to me. Out of interest, is there any reason why we still > have ->exit(), given the zombie process edge case? Surely the zombie > process edge case would cause issues with kmemcg and similar > controllers, if they use ->exit() and not ->free()? No, pids was the only broken one. ->exit() is no longer used but let's see how it goes for a while before getting rid of it. Thanks. -- tejun