From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752497AbbJLPms (ORCPT ); Mon, 12 Oct 2015 11:42:48 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55170 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbbJLPmq (ORCPT ); Mon, 12 Oct 2015 11:42:46 -0400 Date: Mon, 12 Oct 2015 16:42:31 +0100 From: Mark Brown To: Arnd Bergmann Cc: Sascha Hauer , Liam Girdwood , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Message-ID: <20151012154231.GE4238@sirena.org.uk> References: <5130320.kXvB35QoYU@wuerfel> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kbCYTQG2MZjuOjyn" Content-Disposition: inline In-Reply-To: <5130320.kXvB35QoYU@wuerfel> X-Cookie: Oh, so there you are! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2a01:348:6:8808:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH] regulator: core: avoid unused variable warning X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --kbCYTQG2MZjuOjyn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 09, 2015 at 02:36:47PM +0200, Arnd Bergmann wrote: > The second argument of the mutex_lock_nested() helper is only > evaluated if CONFIG_DEBUG_LOCK_ALLOC is set. Otherwise we > get this build warning for the new regulator_lock_supply > function: Shouldn't we have an annotation or something for this in mutex_lock_nested()? It seems like something that might come up elsewhere and it's a bit of a surprise to have one of the arguments there not be evaluated. --kbCYTQG2MZjuOjyn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWG9TmAAoJECTWi3JdVIfQ9u8H/19tVHbxV/NEbAMr7XwJ+sjL QjuAYSbG2PQUiPE9XrJNMDg3Q3fp5bgLXXaxDlS6xwyIwDVn4msaA7AOEw+C9V6N nBzRt8jNwHVW4ulC6Rao8K3NkDQzZVRcs98FCVgzqHGl7LLJvpiRggRTVhZynfYm Pyd8AY9c4f6IlnJTi288oL7l9zaJcF8beft26+2px5mcQLWH95ycvwwah3XOPcuO T6XGLZBDpcbyDBxLx6igJqL7TkD4ZBfv76wzV2qqpHxwgLoCV5SProwUp6/QYCS8 lvcD4gNigh2OPVrIhuw9F5f5jsty4crPiAXxw1BZWM1sIjgNWGtaZEZm56butig= =ykw1 -----END PGP SIGNATURE----- --kbCYTQG2MZjuOjyn--