From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751633AbbJLQ1M (ORCPT ); Mon, 12 Oct 2015 12:27:12 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55229 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbbJLQ1I (ORCPT ); Mon, 12 Oct 2015 12:27:08 -0400 Date: Mon, 12 Oct 2015 17:26:58 +0100 From: Mark Brown To: Markus Pargmann Cc: yalin wang , gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org Message-ID: <20151012162658.GH4238@sirena.org.uk> References: <1444377082-22525-1-git-send-email-yalin.wang2010@gmail.com> <20151012104858.GA6786@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wZdghQXYJzyo6AGC" Content-Disposition: inline In-Reply-To: <20151012104858.GA6786@pengutronix.de> X-Cookie: Oh, so there you are! User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2a01:348:6:8808:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC V3] regmap: change bool to 1 bit variable in struct regmap X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --wZdghQXYJzyo6AGC Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Oct 12, 2015 at 12:48:58PM +0200, Markus Pargmann wrote: > On Fri, Oct 09, 2015 at 03:51:22PM +0800, yalin wang wrote: > > + /* if set, only the cache is modified not the HW */ > > + bool cache_only; > > + /* if set, only the HW is modified not the cache */ > > + bool cache_bypass; > > + /* if set, the cache contains newer data than the HW */ > > + bool cache_dirty; > Why are these last three variables just moved and not changed to u8 of > size 1? They're exported to debugfs and the relevant debugfs helpers take bool as an argument (actually I've got a feeling the relevant API is changed in -next which is likely to be an issue here...). --wZdghQXYJzyo6AGC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWG99SAAoJECTWi3JdVIfQiIQH+wbkT61wfyc3QlOCw5Wbpo2H XAS5htStn1lOnlZqvhuIPG0wOOGDJnESHL5BeaLsAFCVFWsvK6C6p3yFSFgdE8/I YgDEmNZ94lIB0NSOXPxjMkNQwzy0ix4I65waj7xThaFvrgXSt1UhXg/3QDFr0XnU L3S4FsXM3/wXi6IjqeTaw1qITngl6EAuO1ghjFkUJVQqNVcBW44vtnOx2py8TV12 NP/VEMavdHacCrznYINP8+tXri+dtS8yBQaRumlTyy716ZxHJ3BbLSAel87Y/bU9 4qmmKIOLz4d360cKPKV9p/Gyq2gANqAHv/UbxLujQdHv/RqvzZmufOeD7fOiJe8= =EnbZ -----END PGP SIGNATURE----- --wZdghQXYJzyo6AGC--