From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932234AbbJMLHK (ORCPT ); Tue, 13 Oct 2015 07:07:10 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47290 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751779AbbJMLHI (ORCPT ); Tue, 13 Oct 2015 07:07:08 -0400 Date: Tue, 13 Oct 2015 04:23:08 -0700 (PDT) Message-Id: <20151013.042308.2015873034325925155.davem@davemloft.net> To: sowmini.varadhan@oracle.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rds-devel@oss.oracle.com, ajaykumar.hotchandani@oracle.com, igor.maximov@oracle.com, santosh.shilimkar@oracle.com Subject: Re: [PATCH net-next] RDS: Invoke ->laddr_check() in rds_bind() for explicitly bound transports. From: David Miller In-Reply-To: <20151011204603.GA14646@oracle.com> References: <20151011204603.GA14646@oracle.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 13 Oct 2015 04:07:08 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sowmini Varadhan Date: Sun, 11 Oct 2015 16:46:03 -0400 > The IP address passed to rds_bind() should be vetted by the > transport's ->laddr_check() for a previously bound transport. > This needs to be done to avoid cases where, for example, > the application has asked for an IB transport, > but the IP address passed to bind is only usable on > ethernet interfaces. > > Signed-off-by: Sowmini Varadhan Applied.