From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753036AbbJMLh0 (ORCPT ); Tue, 13 Oct 2015 07:37:26 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:47598 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbbJMLhZ (ORCPT ); Tue, 13 Oct 2015 07:37:25 -0400 Date: Tue, 13 Oct 2015 04:53:23 -0700 (PDT) Message-Id: <20151013.045323.2126402747167465452.davem@davemloft.net> To: ebiederm@xmission.com Cc: dvyukov@google.com, kafai@fb.com, kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org, kaber@trash.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller@googlegroups.com, kcc@google.com, glider@google.com, andreyknvl@google.com, sasha.levin@oracle.com, edumazet@google.com, maze@google.com, eric.dumazet@gmail.com Subject: Re: [PATCH net] ipv6: Don't call with rt6_uncached_list_flush_dev From: David Miller In-Reply-To: <87wpusoz27.fsf_-_@x220.int.ebiederm.org> References: <1444652652.27760.158.camel@edumazet-glaptop2.roam.corp.google.com> <87wpusoz27.fsf_-_@x220.int.ebiederm.org> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 13 Oct 2015 04:37:24 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: ebiederm@xmission.com (Eric W. Biederman) Date: Mon, 12 Oct 2015 11:02:08 -0500 > > As originally written rt6_uncached_list_flush_dev makes no sense when > called with dev == NULL as it attempts to flush all uncached routes > regardless of network namespace when dev == NULL. Which is simply > incorrect behavior. > > Furthermore at the point rt6_ifdown is called with dev == NULL no more > network devices exist in the network namespace so even if the code in > rt6_uncached_list_flush_dev were to attempt something sensible it > would be meaningless. > > Therefore remove support in rt6_uncached_list_flush_dev for handling > network devices where dev == NULL, and only call rt6_uncached_list_flush_dev > when rt6_ifdown is called with a network device. > > Fixes: 8d0b94afdca8 ("ipv6: Keep track of DST_NOCACHE routes in case of iface down/unregister") > Signed-off-by: "Eric W. Biederman" Applied and queued up for -stable, thanks.