From: Martin KaFai Lau <kafai@fb.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: "David Miller" <davem@davemloft.net>,
"Dmitry Vyukov" <dvyukov@google.com>,
kuznet@ms2.inr.ac.ru, jmorris@namei.org, yoshfuji@linux-ipv6.org,
"Patrick McHardy" <kaber@trash.net>,
netdev@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
syzkaller@googlegroups.com, "Kostya Serebryany" <kcc@google.com>,
"Alexander Potapenko" <glider@google.com>,
"Andrey Konovalov" <andreyknvl@google.com>,
"Sasha Levin" <sasha.levin@oracle.com>,
"Eric Dumazet" <edumazet@google.com>,
"Maciej Żenczykowski" <maze@google.com>,
"Eric Dumazet" <eric.dumazet@gmail.com>
Subject: Re: [PATCH net] ipv6: Don't call with rt6_uncached_list_flush_dev
Date: Mon, 12 Oct 2015 17:02:21 -0700 [thread overview]
Message-ID: <20151013000221.GD88112@canlin-mbp1.DHCP.thefacebook.com> (raw)
In-Reply-To: <87wpusoz27.fsf_-_@x220.int.ebiederm.org>
On Mon, Oct 12, 2015 at 11:02:08AM -0500, Eric W. Biederman wrote:
>
> As originally written rt6_uncached_list_flush_dev makes no sense when
> called with dev == NULL as it attempts to flush all uncached routes
> regardless of network namespace when dev == NULL. Which is simply
> incorrect behavior.
Thanks for fixing it.
Reviewed-by: Martin KaFai Lau <kafai@fb.com>
I also tested the following cases with the presence of DST_NOCACHE entries:
1. rmmod e1000.ko while running netperf
2. unshare(CLONE_NEWNET) as reported by Dmitry
Tested-by: Martin KaFai Lau <kafai@fb.com>
next prev parent reply other threads:[~2015-10-13 0:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 9:34 GPF in rt6_uncached_list_flush_dev Dmitry Vyukov
2015-10-12 12:24 ` Eric Dumazet
2015-10-12 15:54 ` Eric W. Biederman
2015-10-12 16:02 ` [PATCH net] ipv6: Don't call with rt6_uncached_list_flush_dev Eric W. Biederman
2015-10-13 0:02 ` Martin KaFai Lau [this message]
2015-10-13 11:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013000221.GD88112@canlin-mbp1.DHCP.thefacebook.com \
--to=kafai@fb.com \
--cc=andreyknvl@google.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=glider@google.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kcc@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=syzkaller@googlegroups.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®