From: Peter Zijlstra <peterz@infradead.org>
To: byungchul.park@lge.com
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org,
yuyang.du@intel.com, pjt@google.com, efault@gmx.de,
tglx@linutronix.de
Subject: Re: [PATCH 1/2] sched: make fair sched class can handle the cgroup change by other class
Date: Tue, 13 Oct 2015 11:06:54 +0200 [thread overview]
Message-ID: <20151013090654.GR3604@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <1444036584-14079-2-git-send-email-byungchul.park@lge.com>
On Mon, Oct 05, 2015 at 06:16:23PM +0900, byungchul.park@lge.com wrote:
> From: Byungchul Park <byungchul.park@lge.com>
>
> Original fair sched class can handle the cgroup change occured within its
> class with task_move_group_fair(), but there is no way to know it if the
> change happened outside. This patch makes the fair sched class can handle
> the change of cgroup which happened even at other sched class.
>
> Additionally, it makes sched_move_task() more flexable so that any other
> sched class can add task_move_group_xx() callback easily in future when
> it is needed.
I don't get the problem... when !fair, set_task_rq() will do what needs
doing.
The only reason we need task_move_group_fair() is the extra accounting
required when we actually _are_ of the fair class, it needs to
unaccount, move and reaccount.
If we're not fair, the whole switched_from/to stuff should do that for
us, no?
So please explain the problem.
next prev parent reply other threads:[~2015-10-13 9:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 9:16 [PATCH 0/2] sched: make fair class handle rq/group changes by outside byungchul.park
2015-10-05 9:16 ` [PATCH 1/2] sched: make fair sched class can handle the cgroup change by other class byungchul.park
2015-10-05 9:37 ` kbuild test robot
2015-10-13 9:06 ` Peter Zijlstra [this message]
2015-10-13 11:26 ` Byungchul Park
2015-10-13 12:04 ` Peter Zijlstra
2015-10-13 12:07 ` Peter Zijlstra
2015-10-13 23:58 ` Byungchul Park
2015-10-05 9:16 ` [PATCH 2/2] sched: make fair sched class can handle migration " byungchul.park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013090654.GR3604@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=byungchul.park@lge.com \
--cc=efault@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pjt@google.com \
--cc=tglx@linutronix.de \
--cc=yuyang.du@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome