mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: He Kuang <hekuang@huawei.com>,
	Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: jolsa@kernel.org, David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <a.p.zijlstra@chello.nl>,
	linux-kernel@vger.kernel.org, Wang Nan <wangnan0@huawei.com>
Subject: build: Fix cross compile build
Date: Tue, 13 Oct 2015 14:43:58 +0200	[thread overview]
Message-ID: <20151013124358.GB9467@krava.brq.redhat.com> (raw)
In-Reply-To: <20151008083004.GB17581@krava.landal.opennet>

On Thu, Oct 08, 2015 at 10:30:04AM +0200, Jiri Olsa wrote:
> On Thu, Oct 08, 2015 at 04:02:48PM +0800, He Kuang wrote:
> > hi, Jirka
> > 
> > On 2015/9/30 14:13, Jiri Olsa wrote:
> > >On Wed, Sep 30, 2015 at 11:18:20AM +0800, He Kuang wrote:
> > >>Hi,
> > >>
> > >>perf cross-compile error dual to fixdep is not a host executable, first bad commit
> > >>is 7c422f557266("tools build: Build fixdep helper from perf and basic libs")
> > >>
> > >>Cross-compiling an aarch64 target on x86_64 host, error like this:
> > >>
> > >>   $ make ARCH=aarch64 O=xx/aarch64 CROSS_COMPILE=aarch64-linux-gnu
> > >>   ...
> > >>   make[3]: *** [xx/aarch64/parse-utils.o] Error 126
> > >>   make[3]: *** Waiting for unfinished jobs....
> > >>   /bin/sh: xx/aarch64//fixdep: cannot execute binary file
> > >>
> > >>   $ uname -a
> > >>   x86_64 x86_64 x86_64 GNU/Linux
> > >>
> > >>   $ file xx/aarch64//fixdep
> > >>   xx/aarch64//fixdep : ELF 64-bit LSB executable, ARM aarch64, version 1
> > >>   (SYSV), dynamically linked, interpreter /lib/ld-linux-aarch64.so.1, for
> > >>   GNU/Linux 3.7.0, not stripped
> > >
> > >hum, we need fixdep to stay the host arch.. I should have seen it :-\
> > >could you please check attached patch?
> > >
> > >thanks,
> > >jirka
> > >
> > 
> > It does not work, 'fixdep' still be compiled as target executable.
> 
> could you please provide output from that build with 'JOBS=1 V=1'
> 
> last chance before I kick myself to actualy setup cross compiling :-\
> 
> thanks,
> jirka

posting patch for the issue

thanks,
jirka


---
He Kuang the new fixdep tool breaks cross compiling. The reason
is it wouldn't get compiled under host arch, but under cross arch
and failed to run.

We need to add support for host side tools build, meanwhile
disabling fixdep usage for cross arch builds.

Reported-by: He Kuang <hekuang@huawei.com>
Link: http://lkml.kernel.org/n/tip-3h8xhjd858qf03mnqbmzfvgl@git.kernel.org
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
---
 tools/build/Makefile.include | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/build/Makefile.include b/tools/build/Makefile.include
index 6572bb023543..4e09ad617a60 100644
--- a/tools/build/Makefile.include
+++ b/tools/build/Makefile.include
@@ -1,6 +1,10 @@
 build := -f $(srctree)/tools/build/Makefile.build dir=. obj
 
+ifdef CROSS_COMPILE
+fixdep:
+else
 fixdep:
 	$(Q)$(MAKE) -C $(srctree)/tools/build fixdep
+endif
 
 .PHONY: fixdep
-- 
2.4.3


  reply	other threads:[~2015-10-13 12:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-30  3:18 [BUG] perf cross-compile error dual to fixdep not host-exe He Kuang
2015-09-30  6:13 ` Jiri Olsa
2015-10-08  8:02   ` He Kuang
2015-10-08  8:30     ` Jiri Olsa
2015-10-13 12:43       ` Jiri Olsa [this message]
2015-10-14 13:15         ` [tip:perf/core] tools build: Fix cross compile build tip-bot for Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013124358.GB9467@krava.brq.redhat.com \
    --to=jolsa@redhat.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@redhat.com \
    --cc=dsahern@gmail.com \
    --cc=hekuang@huawei.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=namhyung@kernel.org \
    --cc=wangnan0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®