From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932526AbbJMOzI (ORCPT ); Tue, 13 Oct 2015 10:55:08 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:38117 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932217AbbJMOzG (ORCPT ); Tue, 13 Oct 2015 10:55:06 -0400 Date: Tue, 13 Oct 2015 16:55:02 +0200 From: Frederic Weisbecker To: Byungchul Park Cc: Peter Zijlstra , mingo@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH v3 2/2] sched: consider missed ticks when updating global cpu load Message-ID: <20151013145501.GB14876@lerouge> References: <1443771974-27077-1-git-send-email-byungchul.park@lge.com> <1443771974-27077-3-git-send-email-byungchul.park@lge.com> <20151002155906.GD3816@twins.programming.kicks-ass.net> <20151004065819.GS6455@byungchulpark-X58A-UD3R> <20151005081555.GF2903@worktop.programming.kicks-ass.net> <20151012174532.GB1113@lerouge> <20151013070436.GO3604@twins.programming.kicks-ass.net> <20151013083718.GT6455@byungchulpark-X58A-UD3R> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151013083718.GT6455@byungchulpark-X58A-UD3R> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 05:37:18PM +0900, Byungchul Park wrote: > > > find out the pending updates from update_process_times() itself and pass > > > it to scheduler_tick() which is the one interested in it. > > > > tick_nohz_handler() calls tick_sched_handler() ?! > > > > And tick_nohz_handler() actually computes the number of ticks -- which > > we then happily ignore. > > > > Why compute it again a few functions down? > > i think so. > > additionally, i think it would be better to assume that scheduler_tick() > handles 1 tick as peter said e.g. because of virt, and to handle the > case caused by full NOHZ *in the nohz related code*. You mean "not to assume" right? > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/