From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932556AbbJMPVQ (ORCPT ); Tue, 13 Oct 2015 11:21:16 -0400 Received: from foss.arm.com ([217.140.101.70]:53650 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932573AbbJMPUR (ORCPT ); Tue, 13 Oct 2015 11:20:17 -0400 Date: Tue, 13 Oct 2015 16:20:11 +0100 From: Catalin Marinas To: Will Deacon Cc: mark.rutland@arm.com, toshi.kani@hp.com, andre.przywara@arm.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, yalin wang , treding@nvidia.com, mingo@kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [RFC] arm64: ioremap: add ioremap_cache macro Message-ID: <20151013152011.GE11573@e104818-lin.cambridge.arm.com> References: <1444616898-5057-1-git-send-email-yalin.wang2010@gmail.com> <20151013141055.GC11573@e104818-lin.cambridge.arm.com> <20151013142326.GM21550@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151013142326.GM21550@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 03:23:27PM +0100, Will Deacon wrote: > On Tue, Oct 13, 2015 at 03:10:55PM +0100, Catalin Marinas wrote: > > On Mon, Oct 12, 2015 at 10:28:18AM +0800, yalin wang wrote: > > > Add ioremap_cache macro, because some code will test if this macro > > > is defined or not, and will generate a generric version if not defined, > > > for example, memremap.c do like this. > > > > > > Signed-off-by: yalin wang > > > --- > > > arch/arm64/include/asm/io.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/include/asm/io.h b/arch/arm64/include/asm/io.h > > > index 44be1e0..d6b620c 100644 > > > --- a/arch/arm64/include/asm/io.h > > > +++ b/arch/arm64/include/asm/io.h > > > @@ -172,6 +172,7 @@ extern void __iomem *ioremap_cache(phys_addr_t phys_addr, size_t size); > > > #define ioremap_wc(addr, size) __ioremap((addr), (size), __pgprot(PROT_NORMAL_NC)) > > > #define ioremap_wt(addr, size) __ioremap((addr), (size), __pgprot(PROT_DEVICE_nGnRE)) > > > #define iounmap __iounmap > > > +#define ioremap_cache ioremap_cache > > > > Applied. Thanks. > > I'm not sure we want this. See: > > https://lkml.org/lkml/2015/10/9/699 Thanks Will and Arnd, I missed this. Patch reverted. -- Catalin