From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932460AbbJMPzu (ORCPT ); Tue, 13 Oct 2015 11:55:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44709 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932274AbbJMPzt (ORCPT ); Tue, 13 Oct 2015 11:55:49 -0400 Date: Tue, 13 Oct 2015 17:55:45 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= To: Paolo Bonzini Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, lersek@redhat.com, stable@vger.kernel.org Subject: Re: [PATCH 2/2] KVM: x86: fix SMI to halted VCPU Message-ID: <20151013155545.GB6877@potion.brq.redhat.com> References: <1444732448-9112-1-git-send-email-pbonzini@redhat.com> <1444732448-9112-3-git-send-email-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1444732448-9112-3-git-send-email-pbonzini@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2015-10-13 12:34+0200, Paolo Bonzini: > An SMI to a halted VCPU must wake it up, hence a VCPU with a pending > SMI must be considered runnable. > > Fixes: 64d6067057d9658acb8675afcfba549abdb7fc16 > Cc: stable@vger.kernel.org > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Radim Krčmář > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > @@ -7781,6 +7781,9 @@ static inline bool kvm_vcpu_has_events(struct kvm_vcpu *vcpu) > + if (test_bit(KVM_REQ_SMI, &vcpu->requests)) (Ah, and refactoring of this API is also on my new TODO.)