From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932428AbbJMQSz (ORCPT ); Tue, 13 Oct 2015 12:18:55 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:57405 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752991AbbJMQSx (ORCPT ); Tue, 13 Oct 2015 12:18:53 -0400 Date: Tue, 13 Oct 2015 12:18:49 -0400 From: Vivien Didelot To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Scott Feldman , Jiri Pirko , Florian Fainelli , Andrew Lunn Subject: Re: [PATCH net-next 0/6] net: dsa: implement port_fdb_dump in drivers Message-ID: <20151013161848.GA5116@ketchup.mtl.sfl> References: <1444750983-14726-1-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444750983-14726-1-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct. Tuesday 13 (42) 11:42 AM, Vivien Didelot wrote: > Not all switch chips provide a Get Next kind of operation to dump FDB entries. > It is preferred to let the driver handle the dump operation the way it works > best for the chip. Thus, drop port_fdb_getnext and implement the port_fdb_dump > operation in DSA, which pushes the switchdev FDB dump callback down to the > drivers. mv88e6xxx is the only driver affected and is updated accordingly. > > Vivien Didelot (6): > net: dsa: mv88e6xxx: write VID outside of VTU Get Next code > net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code > net: dsa: add port_fdb_dump function > net: dsa: mv88e6xxx: implement port_fdb_dump > net: dsa: mv88e6xxx: remove port_fdb_getnext > net: dsa: remove port_fdb_getnext > > drivers/net/dsa/mv88e6171.c | 2 +- > drivers/net/dsa/mv88e6352.c | 2 +- > drivers/net/dsa/mv88e6xxx.c | 140 ++++++++++++++++++++++++-------------------- > drivers/net/dsa/mv88e6xxx.h | 5 +- > include/net/dsa.h | 8 ++- > net/dsa/slave.c | 26 +------- > 6 files changed, 90 insertions(+), 93 deletions(-) I mispaste a few "return err" instead of "goto unlock" which skips a few mutex_unlock() in mv88e6xxx.c. I'm sending a respin right away, please ignore this v1. Sorry, -v