From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932742AbbJMSLT (ORCPT ); Tue, 13 Oct 2015 14:11:19 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:33680 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753127AbbJMSLR (ORCPT ); Tue, 13 Oct 2015 14:11:17 -0400 Date: Tue, 13 Oct 2015 14:11:14 -0400 From: Vivien Didelot To: Florian Fainelli Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Scott Feldman , Jiri Pirko , Andrew Lunn Subject: Re: [PATCH net-next v2 3/6] net: dsa: mv88e6xxx: write MAC outside of ATU Get Next code Message-ID: <20151013181114.GA29391@ketchup.mtl.sfl> References: <1444754783-26975-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1444754783-26975-4-git-send-email-vivien.didelot@savoirfairelinux.com> <561D40E9.8030602@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561D40E9.8030602@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct. Tuesday 13 (42) 10:35 AM, Florian Fainelli wrote: > On 13/10/15 09:46, Vivien Didelot wrote: > > There is no need to write the MAC address before every Get Next > > operation, since ATU MAC registers are not cleared between calls. > > > > Move the _mv88e6xxx_atu_mac_write call outside of _mv88e6xxx_atu_getnext > > so future code could call ATU Get Next multiple times and save a few > > register access. > > Missing SoB tag here. Damn, good catch. Can I add it in reply to the patch, or should I send a v3? Thanks, -v