From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752060AbbJMS6E (ORCPT ); Tue, 13 Oct 2015 14:58:04 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:37927 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750903AbbJMS6C (ORCPT ); Tue, 13 Oct 2015 14:58:02 -0400 Date: Tue, 13 Oct 2015 20:57:50 +0200 From: Steffen Trumtrar To: atull@opensource.altera.com Cc: dinguyen@opensource.altera.com, Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Rob Herring , Kumar Gala , delicious.quinoa@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: socfpga: dts: add fpga manager Message-ID: <20151013185750.GB17155@pengutronix.de> References: <1444760900-1373-1-git-send-email-atull@opensource.altera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444760900-1373-1-git-send-email-atull@opensource.altera.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 20:56:52 up 24 days, 8:26, 83 users, load average: 0.25, 0.22, 0.17 User-Agent: Mutt/1.5.21 (2010-09-15) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: str@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alan! On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull@opensource.altera.com wrote: > From: Alan Tull > > Add FPGA manager to device tree for SoCFPGA. > > Signed-off-by: Alan Tull > --- > arch/arm/boot/dts/socfpga.dtsi | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi > index 314e589..e37ba11 100644 > --- a/arch/arm/boot/dts/socfpga.dtsi > +++ b/arch/arm/boot/dts/socfpga.dtsi > @@ -834,5 +834,12 @@ > compatible = "altr,sys-mgr", "syscon"; > reg = <0xffd08000 0x4000>; > }; > + > + hps_0_fpgamgr: fpgamgr@0xff706000 { > + compatible = "altr,socfpga-fpga-mgr"; > + reg = <0xFF706000 0x1000 > + 0xFFB90000 0x1000>; > + interrupts = <0 175 4>; > + }; > }; > }; Please keep the format in line with the rest of the file: Hexvalues are lowercase and no 0x after the "fpgamgr@". I'd say "And please put the node in its proper position according to its address", but I see just now, that the dtsi is all messed up right now anyway :-( Regards, Steffen -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |