From: Steven Rostedt <rostedt@goodmis.org>
To: Dmitry Safonov <0x7f454c46@gmail.com>
Cc: mingo@redhat.com, corbet@lwn.net, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] ftrace: remove redundant strsep in mod_callback
Date: Tue, 13 Oct 2015 20:48:42 -0400 [thread overview]
Message-ID: <20151013204842.4d43cdfb@grimm.local.home> (raw)
In-Reply-To: <1443545176-3215-1-git-send-email-0x7f454c46@gmail.com>
On Tue, 29 Sep 2015 19:46:12 +0300
Dmitry Safonov <0x7f454c46@gmail.com> wrote:
> - ret = ftrace_match_module_records(hash, func, mod);
> - if (!ret)
> - ret = -EINVAL;
> + ret = ftrace_match_module_records(hash, func, param);
> + if (ret == 0)
Small nit, personally, I prefer the if (!ret) version.
For me "== 0" is for counters and strcmp. I may change this to be
consistent with the rest of the code.
-- Steve
> + return -EINVAL;
> if (ret < 0)
> return ret;
>
next prev parent reply other threads:[~2015-10-14 0:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 16:46 Dmitry Safonov
2015-09-29 16:46 ` [PATCH 2/5] ftrace: clarify code for mod command Dmitry Safonov
2015-09-29 16:46 ` [PATCH 3/5] ftrace: introduce ftrace_glob structure Dmitry Safonov
2015-10-16 15:05 ` Steven Rostedt
2015-10-16 22:32 ` Dmitry Safonov
2015-09-29 16:46 ` [PATCH 4/5] ftrace: add module globbing Dmitry Safonov
2015-09-29 16:46 ` [PATCH 5/5] Documentation: ftrace: module globbing usage Dmitry Safonov
2015-09-29 19:11 ` [PATCH 1/5] ftrace: remove redundant strsep in mod_callback Steven Rostedt
2015-10-05 15:16 ` Дмитрий Сафонов
2015-10-14 0:48 ` Steven Rostedt [this message]
2015-10-16 8:52 ` Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013204842.4d43cdfb@grimm.local.home \
--to=rostedt@goodmis.org \
--cc=0x7f454c46@gmail.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome