From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753012AbbJNIih (ORCPT ); Wed, 14 Oct 2015 04:38:37 -0400 Received: from mail-wi0-f180.google.com ([209.85.212.180]:37893 "EHLO mail-wi0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbbJNIi3 (ORCPT ); Wed, 14 Oct 2015 04:38:29 -0400 Date: Wed, 14 Oct 2015 10:38:27 +0200 From: Michal Hocko To: Pan Xinhui Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , vbabka@suse.cz, rientjes@google.com, hannes@cmpxchg.org, nasa4836@gmail.com, mgorman@suse.de, alexander.h.duyck@redhat.com, aneesh.kumar@linux.vnet.ibm.com, "yanmin_zhang@linux.intel.com" Subject: Re: [PATCH] gfp: GFP_RECLAIM_MASK should include __GFP_NO_KSWAPD Message-ID: <20151014083827.GG28333@dhcp22.suse.cz> References: <561DE9F3.504@intel.com> <20151014073428.GC28333@dhcp22.suse.cz> <561E0F9B.6090305@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <561E0F9B.6090305@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 14-10-15 16:17:31, Pan Xinhui wrote: [...] > I have a look at Mel's patchset. yes, it can help fix my kswapd issue. > :) So I just need change my kmalloc's gfp_flag to GFP_ATOMIC &~ > __GFP_KSWAPD_RECLAIM, then slub will not wakeup kswpad. As pointed out in my other email __GFP_ATOMIC would be more appropriate because you shouldn't abuse memory reserves which are implicitly used for GFP_ATOMIC requests. -- Michal Hocko SUSE Labs