From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752742AbbJNKhN (ORCPT ); Wed, 14 Oct 2015 06:37:13 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58277 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751889AbbJNKhL (ORCPT ); Wed, 14 Oct 2015 06:37:11 -0400 Date: Wed, 14 Oct 2015 11:36:48 +0100 From: Mark Brown To: Hans de Goede Cc: Chen-Yu Tsai , Mark Rutland , Jean-Christophe Plagniol-Villard , Tomi Valkeinen , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Maxime Ripard , "linux-fbdev@vger.kernel.org" , devicetree , linux-kernel , linux-arm-kernel Message-ID: <20151014103648.GS14956@sirena.org.uk> References: <1444669458-5588-1-git-send-email-wens@csie.org> <1444669458-5588-2-git-send-email-wens@csie.org> <20151012171018.GB3659@leverpostej> <561CADFE.2010609@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OowMmFE4aK71mEhh" Content-Disposition: inline In-Reply-To: <561CADFE.2010609@redhat.com> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH RFC 1/2] dt-bindings: simplefb: Support a list of regulator supply properties X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OowMmFE4aK71mEhh Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 13, 2015 at 09:08:46AM +0200, Hans de Goede wrote: > On 13-10-15 04:22, Chen-Yu Tsai wrote: > >On Tue, Oct 13, 2015 at 1:10 AM, Mark Rutland wrote: > >>On Tue, Oct 13, 2015 at 01:04:17AM +0800, Chen-Yu Tsai wrote: > >>>+- num-supplies : The number of regulators used by the framebuffer. > >>>+- vinN-supply : The N-th (from 0) regulator used by the framebuffer. > >>I don't see why you need num-supplies. Why not just try probing > >>vin${N}-supply until such a property isn't present in the DT? > +1 for this. Even better would be to just enumerate all the properties on the node and request anything with a FOO-supply name. That way we can keep using standard regulator bindings that name the supplies after their actual names on the device. > > That's doable. Though I'd add a hard limit on it. Does 16 seem > > reasonable? > I would not add a hard limit to the binding, you can use a fixed array in > the code to make the code simpler. I would say 8 should be sufficient, since > the limit will only be in the code we can always bump it when we need > to. Or just dynamically allocate the array and resize as needed if it starts to get to be a problem. --OowMmFE4aK71mEhh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWHjBAAAoJECTWi3JdVIfQK/AH/1yPlf11H6nCC5On09TjJ5Ar vHQQf90Avaj6fFtPeB23iarIAYHa5xb3J5kn/HPEakh3G1s8lchURSKihGs3aIdK B11neQeJ0eJCRwFK3UJH/iUhx6J9EYK3OU/I3G1fwGNuMxjAfrCC4EzEVPiyTBzR QabqtJo1MU+Wg8S7BMETD30sx8LUjYWuuRdzuo72r3DZ9s9iVc0OQivKPg1CxYsb 5+Bsh1U0oz+gDBdk7D8y7jVX7qqK0oZjj9ULLGUsMMwS70nl1m/ZCqSk06yU1sTl DsnPDU3ARCrhlSFOqjzo4ksJTeSFxfQdAviu+56Im/O+rA8u0VY5gHzgApkOPDM= =TZzQ -----END PGP SIGNATURE----- --OowMmFE4aK71mEhh--