From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753348AbbJNK5L (ORCPT ); Wed, 14 Oct 2015 06:57:11 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:58317 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751990AbbJNK5H (ORCPT ); Wed, 14 Oct 2015 06:57:07 -0400 Date: Wed, 14 Oct 2015 11:56:59 +0100 From: Mark Brown To: Michael Welling Cc: Neil Armstrong , linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Fionn Cleary , Wolfram Sang , Jarkko Nikula , Sebastian Reichel Message-ID: <20151014105659.GU14956@sirena.org.uk> References: <5616816C.9020904@baylibre.com> <20151008152105.GA13157@deathstar> <20151009113810.GD1542@sirena.org.uk> <20151009142451.GA25376@deathstar> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qa1NXTiqN6KSzHv0" Content-Disposition: inline In-Reply-To: <20151009142451.GA25376@deathstar> X-Cookie: Do you like "TENDER VITTLES"? User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [RFC PATCH] spi: omap2-mcspi: disable other channels CHCONF_FORCE in prepare_message X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --qa1NXTiqN6KSzHv0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Oct 09, 2015 at 09:24:51AM -0500, Michael Welling wrote: > On Fri, Oct 09, 2015 at 12:38:10PM +0100, Mark Brown wrote: > > On Thu, Oct 08, 2015 at 10:21:05AM -0500, Michael Welling wrote: > > > On Thu, Oct 08, 2015 at 04:45:00PM +0200, Neil Armstrong wrote: > > > What is the point of doing this void cast below? > > > Avoiding compiler warning perhaps? > > > Perhaps you can __maybe_unused for the variable instead? > > > > + /* Ignore message */ > > > > + (void)msg; > > You shouldn't need it at all, but yes if there is a good reason to mark > > something as unused the above annotation is better. > Which one? __maybe_unused. --qa1NXTiqN6KSzHv0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWHjT7AAoJECTWi3JdVIfQ4c0H/30Ifkg0CLxBPxkYNQOurf8c ORL+JKikloHu3gKvzYBwz1kJyPpcUXSZQbf6JWPtNXku4mObq9S2ubpaDRv3oUfV d4J8vvCKe1BSvIScmMro/+yGkfx2Md9+DE1Pe2WG2iUm/LvLpSUzGFbYXajsgLAe /fo9jQT+WDOTREpOCJ37PhHfXt+8DNiR5+XKYQ1KNeL7briKj1saZZjaxFMeKuAt dbVZc8qAPYmKnAzSdVNWw2lEKWdNy+3oURfk8AcSMSJlFbxqLw05jjmoy/8Dw9P+ yRbg6I/PGceKVbTp/WSZhmX/uC3i1pQfg3zUmdf0kx5d+WJQW6pfX1YXPlvuqwM= =MpAa -----END PGP SIGNATURE----- --qa1NXTiqN6KSzHv0--