From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbbJNMSu (ORCPT ); Wed, 14 Oct 2015 08:18:50 -0400 Received: from 8bytes.org ([81.169.241.247]:48715 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752025AbbJNMSp (ORCPT ); Wed, 14 Oct 2015 08:18:45 -0400 Date: Wed, 14 Oct 2015 14:18:43 +0200 From: Joerg Roedel To: Chen Feng Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, haojian.zhuang@linaro.org, devicetree@vger.kernel.org, xuwei5@hisilicon.com, xuyiping@hisilicon.com, w.f@huawei.com, kong.kongxinwei@hisilicon.com, z.liuxinliang@hisilicon.com, yudongbin@hisilicon.com, weidong2@hisilicon.com, saberlily.xia@hisilicon.com, linuxarm@huawei.com, dan.zhao@hisilicon.com, peter.panshilin@hisilicon.com, qijiwen@hisilicon.com Subject: Re: [PATCH 2/3] iommu/hisilicon: Add hi6220 iommu driver Message-ID: <20151014121843.GN27420@8bytes.org> References: <1444290348-66509-1-git-send-email-puck.chen@hisilicon.com> <1444290348-66509-2-git-send-email-puck.chen@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444290348-66509-2-git-send-email-puck.chen@hisilicon.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 08, 2015 at 03:45:47PM +0800, Chen Feng wrote: > +static int hi6220_smmu_attach_dev(struct iommu_domain *domain, > + struct device *dev) > +{ > + struct hi6220_domain *m_domain = to_hi6220_domain(domain); > + > + smmu_domain_prepare(m_domain); > + dev->archdata.iommu = &m_domain->smmu_dev->iova_allocator; > + > + return 0; > +} What happens when you attach devices behind different smmus to one domain? Will that overwrite the smmu_dev pointer in the domain? > +static size_t hi6220_smmu_unmap(struct iommu_domain *domain, unsigned long iova, > + size_t size) > +{ > + struct hi6220_domain *m_domain = to_hi6220_domain(domain); > + size_t page_size = m_domain->smmu_dev->page_size; > + struct hi6220_smmu *smmu_dev = m_domain->smmu_dev; > + int *page_table = (unsigned int *)smmu_dev->pgtable_virt; > + > + if (size != page_size) { > + pr_err("unmap size error, only support %zd\n", page_size); > + return 0; > + } > + > + __clear_smmu_pte(page_table + IOVA_PFN(iova)); > + > + return page_size; > +} Don't you need a call to __invalid_smmu_tlb here too? Joerg