From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754070AbbJNONs (ORCPT ); Wed, 14 Oct 2015 10:13:48 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:44596 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753771AbbJNONq (ORCPT ); Wed, 14 Oct 2015 10:13:46 -0400 Date: Wed, 14 Oct 2015 22:13:43 +0800 From: Herbert Xu To: Sudip Mukherjee Cc: "David S. Miller" , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: ccm - remove goto Message-ID: <20151014141343.GA17325@gondor.apana.org.au> References: <1444724305-3235-1-git-send-email-sudipm.mukherjee@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444724305-3235-1-git-send-email-sudipm.mukherjee@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 13, 2015 at 01:48:25PM +0530, Sudip Mukherjee wrote: > Instead of using goto and jumping to a label and then returning from > there, lets return directly. The label out: is not used from anywhere > else in the code. > > Signed-off-by: Sudip Mukherjee I don't think patch improves the code so I'm not taking it. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt