mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <fengguang.wu@intel.com>
To: Alexandre Courbot <acourbot@nvidia.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	Ben Skeggs <bskeggs@redhat.com>
Subject: drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c:201:1-3: WARNING: PTR_ERR_OR_ZERO can be used
Date: Wed, 14 Oct 2015 18:10:43 +0800	[thread overview]
Message-ID: <201510141834.GK2znjC3%fengguang.wu@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   5b5f1455272e23f4e7889cec37228802d8d01adf
commit: c4d0f8f6f8c8dc09cd32e7fdb31e3d1a65a0f8f1 drm/nouveau/gr/gk20a: use same initialization sequence as nvgpu
date:   7 weeks ago


coccinelle warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c:201:1-3: WARNING: PTR_ERR_OR_ZERO can be used

vim +201 drivers/gpu/drm/nouveau/nvkm/engine/gr/gk20a.c

   185		if (IS_ERR(priv->fuc_sw_ctx))
   186			return PTR_ERR(priv->fuc_sw_ctx);
   187	
   188		err = gf100_gr_ctor_fw(priv, "sw_bundle_init", &fuc);
   189		if (err)
   190			return err;
   191		priv->fuc_bundle = gk20a_gr_av_to_init(&fuc);
   192		gf100_gr_dtor_fw(&fuc);
   193		if (IS_ERR(priv->fuc_bundle))
   194			return PTR_ERR(priv->fuc_bundle);
   195	
   196		err = gf100_gr_ctor_fw(priv, "sw_method_init", &fuc);
   197		if (err)
   198			return err;
   199		priv->fuc_method = gk20a_gr_av_to_method(&fuc);
   200		gf100_gr_dtor_fw(&fuc);
 > 201		if (IS_ERR(priv->fuc_method))
   202			return PTR_ERR(priv->fuc_method);
   203	
   204		return 0;
   205	}
   206	
   207	static void
   208	gk20a_gr_dtor(struct nvkm_object *object)
   209	{

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

                 reply	other threads:[~2015-10-14 10:11 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201510141834.GK2znjC3%fengguang.wu@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=acourbot@nvidia.com \
    --cc=bskeggs@redhat.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®