mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: dave penkler <dpenkler@gmail.com>
Cc: kbuild-all@01.org, gregkh@linuxfoundation.org,
	peter.chen@freescale.com, teuniz@gmail.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: usbtmc: Add support for missing USBTMC-USB488 spec
Date: Wed, 14 Oct 2015 22:20:06 +0800	[thread overview]
Message-ID: <201510142249.m4Pw2ldb%fengguang.wu@intel.com> (raw)
In-Reply-To: <20151014131309.GB5410@slacky>

Hi dave,

[auto build test WARNING on usb/usb-next -- if it's inappropriate base, please suggest rules for selecting the more suitable base]

url:    https://github.com/0day-ci/linux/commits/dave-penkler/USB-usbtmc-Add-support-for-missing-USBTMC-USB488-spec/20151014-211711
reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/usb/class/usbtmc.c:476:28: sparse: incorrect type in argument 1 (different address spaces)
   drivers/usb/class/usbtmc.c:476:28:    expected void [noderef] <asn:1>*to
   drivers/usb/class/usbtmc.c:476:28:    got void *<noident>
>> drivers/usb/class/usbtmc.c:507:44: sparse: incorrect type in argument 2 (different address spaces)
   drivers/usb/class/usbtmc.c:507:44:    expected void const [noderef] <asn:1>*from
   drivers/usb/class/usbtmc.c:507:44:    got void *<noident>
   drivers/usb/class/usbtmc.c:1248:40: sparse: incorrect type in argument 1 (different address spaces)
   drivers/usb/class/usbtmc.c:1248:40:    expected void [noderef] <asn:1>*to
   drivers/usb/class/usbtmc.c:1248:40:    got void *<noident>

vim +476 drivers/usb/class/usbtmc.c

   470	
   471		/* bump interrupt bTag */
   472		data->iin_bTag += 1;
   473		if (data->iin_bTag > 127)
   474			data->iin_bTag = 2;
   475	
 > 476		rv = copy_to_user((void *)arg, &stb, sizeof(stb));
   477		if (rv)
   478			rv = -EFAULT;
   479	
   480	 exit:
   481		kfree(buffer);
   482		return rv;
   483	
   484	}
   485	
   486	static int usbtmc488_ioctl_simple(struct usbtmc_device_data *data,
   487					unsigned long arg,
   488					unsigned int cmd)
   489	{
   490		u8 *buffer;
   491		struct device *dev;
   492		int rv;
   493		unsigned int val;
   494		u16 wValue;
   495	
   496		dev = &data->intf->dev;
   497	
   498		if (0 == (data->usb488_caps & USBTMC488_CAPABILITY_SIMPLE))
   499			return -EINVAL;
   500	
   501		buffer = kmalloc(8, GFP_KERNEL);
   502		if (!buffer)
   503			return -ENOMEM;
   504	
   505	
   506		if (cmd == USBTMC488_REQUEST_REN_CONTROL) {
 > 507			rv = copy_from_user(&val, (void *)arg, sizeof(val));
   508			if (rv) {
   509				rv = -EFAULT;
   510				goto exit;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

      parent reply	other threads:[~2015-10-14 14:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 13:13 dave penkler
2015-10-14 13:33 ` Oliver Neukum
2015-10-14 14:31   ` dave penkler
2015-10-14 14:20 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201510142249.m4Pw2ldb%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=dpenkler@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@freescale.com \
    --cc=teuniz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®