From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753452AbbJPGP4 (ORCPT ); Fri, 16 Oct 2015 02:15:56 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:51254 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbbJPGPy (ORCPT ); Fri, 16 Oct 2015 02:15:54 -0400 Date: Thu, 15 Oct 2015 23:31:57 -0700 (PDT) Message-Id: <20151015.233157.923931397415718098.davem@davemloft.net> To: wuninsu@gmail.com Cc: amirv@mellanox.com, maorg@mellanox.com, ogerlitz@mellanox.com, jackm@dev.mellanox.co.il, yishaih@mellanox.com, viro@ZenIV.linux.org.uk, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, taesoo@gatech.edu, yeongjin.jang@gatech.edu, insu@gatech.edu Subject: Re: [PATCH] mlx4: corretly check failed allocation From: David Miller In-Reply-To: <1444926249-29033-1-git-send-email-wuninsu@gmail.com> References: <1444926249-29033-1-git-send-email-wuninsu@gmail.com> X-Mailer: Mew version 6.4 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 15 Oct 2015 23:15:54 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Insu Yun Date: Thu, 15 Oct 2015 12:24:09 -0400 > When allocation fails, mlx4_alloc_cmd_mailbox returns -ENOMEM. > Since there is no case that mlx4_alloc_cmd_mailbox returns NULL, > it needs to be checked by IS_ERR, not IS_ERR_OR_NULL > > Signed-off-by: Insu Yun Applied to net-next, thanks.