From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbbJOI5S (ORCPT ); Thu, 15 Oct 2015 04:57:18 -0400 Received: from pandora.arm.linux.org.uk ([78.32.30.218]:37199 "EHLO pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbbJOI5M (ORCPT ); Thu, 15 Oct 2015 04:57:12 -0400 Date: Thu, 15 Oct 2015 09:57:00 +0100 From: Russell King - ARM Linux To: Shengjiu Wang Cc: nico@linaro.org, ard.biesheuvel@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: SWP emulation: Restore original *data when failed Message-ID: <20151015085700.GY32532@n2100.arm.linux.org.uk> References: <1444791077-26020-1-git-send-email-shengjiu.wang@freescale.com> <20151015082417.GX32532@n2100.arm.linux.org.uk> <20151015083629.GA32630@shlinux2> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151015083629.GA32630@shlinux2> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 15, 2015 at 04:36:31PM +0800, Shengjiu Wang wrote: > On Thu, Oct 15, 2015 at 09:24:17AM +0100, Russell King - ARM Linux wrote: > > On Wed, Oct 14, 2015 at 10:51:17AM +0800, Shengjiu Wang wrote: > > > __user_swpX_asm maybe failed in first STREX operation, emulate_swpX > > > will try again, but the *data has been changed in first time. which > > > cause the result is wrong. So need to recover the *data when failed. > > > > > > Signed-off-by: Shengjiu Wang > > > --- > > > arch/arm/kernel/swp_emulate.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/kernel/swp_emulate.c b/arch/arm/kernel/swp_emulate.c > > > index 5b26e7e..c61fbf92 100644 > > > --- a/arch/arm/kernel/swp_emulate.c > > > +++ b/arch/arm/kernel/swp_emulate.c > > > @@ -41,6 +41,7 @@ > > > "1: strex"B" %0, %2, [%3]\n" \ > > > " cmp %0, #0\n" \ > > > " movne %0, %4\n" \ > > > + " movne %1, %2\n" \ > > > "2:\n" \ > > > " .section .text.fixup,\"ax\"\n" \ > > > " .align 2\n" \ > > > > I think I'd prefer this to be: > > > > __asm__ __volatile__( \ > > "0: ldrex"B" %2, [%3]\n" \ > > "1: strex"B" %0, %1, [%3]\n" \ > > " cmp %0, #0\n" \ > > " moveq %1, %2\n" \ > > " movne %0, %4\n" \ > > > > so that we're not loading into %1 (an in-out non-temporary) but rather > > loading it into a temporary - and only overwriting the saved register > > value if the swap succeeds. > > > > Thanks. > > I am ok with your change. Need I send another patch for this change? or will > you send it by yourself? Please send a new patch, thanks. -- FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.