From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbbJOJOf (ORCPT ); Thu, 15 Oct 2015 05:14:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35224 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbbJOJOb (ORCPT ); Thu, 15 Oct 2015 05:14:31 -0400 Date: Thu, 15 Oct 2015 17:14:18 +0800 From: Dave Young To: Borislav Petkov Cc: LKML , Andrew Morton , Andy Lutomirski , "H. Peter Anvin" , Ingo Molnar , jerry_hoemann@hp.com, Jiri Kosina , Joerg Roedel , Juergen Gross , Mark Salter , Thomas Gleixner , WANG Chao , x86-ml Subject: Re: [PATCH 0/5] x86/setup/crash: Cleanup some code Message-ID: <20151015091418.GC4795@dhcp-129-3.nay.redhat.com> References: <1444897231-7906-1-git-send-email-bp@alien8.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1444897231-7906-1-git-send-email-bp@alien8.de> User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/15/15 at 10:20am, Borislav Petkov wrote: > From: Borislav Petkov > > Hi all, > > this is ontop of Baoquan's fix from yesterday: > https://lkml.kernel.org/r/20151014104338.GA8235@pd.tnic > > Looking at the crashkernel reservation code made a couple of style > problems wink at me so this short cleanup should address them. Please > take a look and complain if something's wrong. > > Thanks. > > Borislav Petkov (5): > x86/setup: Cleanup crashkernel reservation functions > x86/setup/crash: Remove alignment variable > x86/setup/crash: Cleanup some more > x86/setup/crash: Check memblock_reserve() retval > kexec/crash: Say which char is the unrecognized > > arch/x86/kernel/setup.c | 81 +++++++++++++++++++++++++------------------------ > kernel/kexec_core.c | 6 ++-- > 2 files changed, 45 insertions(+), 42 deletions(-) > > -- > 2.3.5 > > Reviewed-by: Dave Young Thanks Dave