From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752347AbbJOJTD (ORCPT <rfc822;w@1wt.eu>);
	Thu, 15 Oct 2015 05:19:03 -0400
Received: from mx1.redhat.com ([209.132.183.28]:49281 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751764AbbJOJSj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 15 Oct 2015 05:18:39 -0400
Date: Thu, 15 Oct 2015 17:18:26 +0800
From: Dave Young <dyoung@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andy Lutomirski <luto@amacapital.net>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
        jerry_hoemann@hp.com, Jiri Kosina <jkosina@suse.cz>,
        Joerg Roedel <jroedel@suse.de>, Juergen Gross <jgross@suse.com>,
        Mark Salter <msalter@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        WANG Chao <chaowang@redhat.com>, x86-ml <x86@kernel.org>
Subject: Re: [PATCH 4/5] x86/setup/crash: Check memblock_reserve() retval
Message-ID: <20151015091826.GD4795@dhcp-129-3.nay.redhat.com>
References: <1444897231-7906-1-git-send-email-bp@alien8.de>
 <1444897231-7906-5-git-send-email-bp@alien8.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1444897231-7906-5-git-send-email-bp@alien8.de>
User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/15/15 at 10:20am, Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> 
> memblock_reserve() can fail but the crashkernel reservation code
> doesn't check that and this can lead the user into believing that the
> crashkernel region was actually reserved. Make sure we check that return
> value and we exit early with a failure message in the error case.
> 
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Andy Lutomirski <luto@amacapital.net>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Ingo Molnar <mingo@kernel.org>
> Cc: jerry_hoemann@hp.com
> Cc: Jiri Kosina <jkosina@suse.cz>
> Cc: Joerg Roedel <jroedel@suse.de>
> Cc: Juergen Gross <jgross@suse.com>
> Cc: Mark Salter <msalter@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: WANG Chao <chaowang@redhat.com>
> Cc: x86-ml <x86@kernel.org>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
>  arch/x86/kernel/setup.c | 12 ++++++++++--
>  1 file changed, 10 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
> index d4788719a1e2..3f75297d5fd0 100644
> --- a/arch/x86/kernel/setup.c
> +++ b/arch/x86/kernel/setup.c
> @@ -531,7 +531,11 @@ static int __init reserve_crashkernel_low(void)
>  		return -ENOMEM;
>  	}
>  
> -	memblock_reserve(low_base, low_size);
> +	ret = memblock_reserve(low_base, low_size);
> +	if (ret) {
> +		pr_err("%s: Error reserving crashkernel low memblock.\n", __func__);
> +		return ret;
> +	}
>  

Seems there's no checking for other callback to memblock_reserve in setup.c
Need another cleanup?

BTW, a further cleanup is reasonable to me, there's a lot of below patter:
memblock_find_in_range
error checking
memblock_reserve
error checking

So a new function memblock_reserve_in_range is reasonable.

Thanks
Dave