From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752490AbbJOOSR (ORCPT <rfc822;w@1wt.eu>);
	Thu, 15 Oct 2015 10:18:17 -0400
Received: from smtprelay0139.hostedemail.com ([216.40.44.139]:33463 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1750820AbbJOOSQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 15 Oct 2015 10:18:16 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:1981:2194:2199:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3352:3622:3865:3867:3868:3871:3872:3873:3874:5007:6261:6742:7875:7903:8660:10004:10400:10450:10455:10481:10848:10967:11232:11658:11914:12517:12519:12663:12740:13069:13148:13230:13311:13357:19900:19904:19999:21060:21080:21212:30003:30012:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:4,LUA_SUMMARY:none
X-HE-Tag: burn65_64f3f8e69d650
X-Filterd-Recvd-Size: 1994
Date: Thu, 15 Oct 2015 10:18:12 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>, linux-arm-kernel@lists.infradead.org,
        Li Bin <huawei.libin@huawei.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Christoffer Dall <christoffer.dall@linaro.org>,
        Punit Agrawal <punit.agrawal@arm.com>,
        Mark Rutland <mark.rutland@arm.com>, zhouchengming1@huawei.com,
        xiexiuqi@huawei.com, dingtianhong@huawei.com,
        linux-kernel@vger.kernel.org, guohanjun@huawei.com
Subject: Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in
 call trace
Message-ID: <20151015101812.7cb6e917@gandalf.local.home>
In-Reply-To: <20151015125133.GA29301@arm.com>
References: <1444911155-17480-1-git-send-email-huawei.libin@huawei.com>
	<6277407.jveniKQDxt@wuerfel>
	<20151015125133.GA29301@arm.com>
X-Mailer: Claws Mail 3.12.0 (GTK+ 2.24.28; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 15 Oct 2015 13:51:33 +0100
Will Deacon <will.deacon@arm.com> wrote:

> Is this the same old problem caused by e306dfd06fcb ("ARM64: unwind: Fix
> PC calculation")? I've said previously that I'm happy to revert that if
> we're the only architecture with this behaviour, but Akashi resisted
> because there are other issues with ftrace that he was hoping to address
> and they would resolve this too.

Just a reference, but this patch is pretty much exactly what x86
currently has. I wonder if I should make that function generic for all
archs to use.

If you accept this patch, I can look at what archs do and pull out the
common code and place it into the core code and have the archs call
that instead.

-- Steve