From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752910AbbJOMg3 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 15 Oct 2015 08:36:29 -0400
Received: from mail-wi0-f173.google.com ([209.85.212.173]:36568 "EHLO
	mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750774AbbJOMg2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 15 Oct 2015 08:36:28 -0400
Date: Thu, 15 Oct 2015 14:36:25 +0200
From: Luis de Bethencourt <luis@debethencourt.com>
To: Eric Anholt <eric@anholt.net>
Cc: linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Stephen Warren <swarren@wwwdotorg.org>,
        Lee Jones <lee@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
        alsa-devel@alsa-project.org, linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: bcm2835-i2s: Fix module autoload for OF platform
 drivers
Message-ID: <20151015123625.GA24671@goodgumbo.baconseed.org>
References: <20150827150401.GA32653@goodgumbo.baconseed.org>
 <8737xdgdtt.fsf@eliezer.anholt.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8737xdgdtt.fsf@eliezer.anholt.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Oct 14, 2015 at 05:44:46PM -0700, Eric Anholt wrote:
> Luis de Bethencourt <luis@debethencourt.com> writes:
> 
> > These platform drivers have a OF device ID table but the OF module
> > alias information is not created so module autoloading won't work.
> >
> > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > ---
> >  sound/soc/bcm/bcm2835-i2s.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/sound/soc/bcm/bcm2835-i2s.c b/sound/soc/bcm/bcm2835-i2s.c
> > index 03fa1cb..8c435be 100644
> > --- a/sound/soc/bcm/bcm2835-i2s.c
> > +++ b/sound/soc/bcm/bcm2835-i2s.c
> > @@ -862,6 +862,8 @@ static const struct of_device_id bcm2835_i2s_of_match[] = {
> >  	{},
> >  };
> >  
> > +MODULE_DEVICE_TABLE(of, bcm2835_i2s_of_match);
> > +
> >  static struct platform_driver bcm2835_i2s_driver = {
> >  	.probe		= bcm2835_i2s_probe,
> >  	.driver		= {
> > -- 
> 
> It looks like this should go through the asoc tree, but I don't see it
> in there.
> 
> FWIW, it is also:
> 
> Acked-by: Eric Anholt <eric@anholt.net>

Hi Eric,

Should I resend adding somebody from the asoc tree to the CC?

Thanks for the review,
Luis