From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753172AbbJOMw1 (ORCPT ); Thu, 15 Oct 2015 08:52:27 -0400 Received: from mail.savoirfairelinux.com ([208.88.110.44]:50865 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752375AbbJOMwZ (ORCPT ); Thu, 15 Oct 2015 08:52:25 -0400 Date: Thu, 15 Oct 2015 08:41:57 -0400 From: Vivien Didelot To: Andrew Lunn Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Guenter Roeck , Florian Fainelli , Neil Armstrong Subject: Re: [PATCH net-next 0/4] net: dsa: mv88e6xxx: fix hardware bridging Message-ID: <20151015124157.GB25443@ketchup.mtl.sfl> References: <1444601318-20561-1-git-send-email-vivien.didelot@savoirfairelinux.com> <20151014224617.GA10146@lunn.ch> <20151015012854.GA10868@ketchup.lan> <20151015025250.GA12436@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151015025250.GA12436@lunn.ch> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Oct. Thursday 15 (42) 04:52 AM, Andrew Lunn wrote: > On Wed, Oct 14, 2015 at 09:28:55PM -0400, Vivien Didelot wrote: > > On Oct. Thursday 15 (42) 12:46 AM, Andrew Lunn wrote: > > > On Sun, Oct 11, 2015 at 06:08:34PM -0400, Vivien Didelot wrote: > > > > DSA and its drivers currently hook the NETDEV_CHANGEUPPER net_device event in > > > > order to configure the VLAN map of every port. > > > > > > > > This VLAN map is a feature of these switch chips to hardcode and restrict which > > > > output ports a given input port can egress frames to. > > > > > > > > A Linux bridge is a simple untagged VLAN propagated by the bridge code itself. > > > > With a proper 802.1Q support, a driver does not need this hook anymore, and > > > > will simply program the related VLAN object. > > > > > > > > This patchset improves the hardware bridging code in the mv88e6xxx driver with > > > > a strict 802.1Q mode. > > > > > > Hi Vivien > > > > > > I just tested this as part of net-next/master, and found a problem.... > > > > > > If i do: > > > > > > ip link set lan0 up > > > ip addr add 192.168.10.2/24 dev lan0 > > > > > > It will not ping. Looking in sys/kernel/debug/dsa0/stats i see > > > broadcast packets, probably ARP, being received at the port. > > > But they are not being forwarded out the CPU port. > > > > > > If however i do > > > > > > brctl addbr br0 > > > brctl addif br0 lan0 > > > ip addr add 192.168.10.2/24 dev br0 > > > ip link set br0 up > > > > > > i can ping. > > > > > > So it looks like we are too restrictive by default. You should be able > > > to use interfaces as they are, without a bridge. > > > > Correct, if the ports are not in a VLAN by default, they cannot talk. > > Hi Vivien > > This is a regression. Ports of the switch should work like normal > Linux interfaces. And up until now, they did. This patchset changed > that. > > As Florian pointed out, these interfaces are separated from each > other. So you need something like a bridge per port by default, which > then gets removed and replaced when a port is added to a Linux bridge. I'll fix this regression and try the exact same example you provided. > We also need to take care of VLANs. When the port is not a member of a > linux bridge, i expect all VLAN tagged frames to be received, as well > as untagged frames. This is normal Linux behaviour. But i never got > around to testing this with DSA. Thanks for testing, -v