From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: Nathan Lynch <nathan_lynch@mentor.com>,
Szabolcs Nagy <szabolcs.nagy@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, marek@goldelico.com
Subject: Re: [PATCH v2] ARM: fix vdsomunge not to depend on glibc specific byteswap.h
Date: Thu, 15 Oct 2015 17:37:12 +0100 [thread overview]
Message-ID: <20151015163712.GD32532@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <350DE2A3-622F-4624-8AFC-D0F37CCB29EA@goldelico.com>
On Thu, Oct 15, 2015 at 07:52:38AM +0200, H. Nikolaus Schaller wrote:
> ERROR: space prohibited before that close parenthesis ')'
> #46: FILE: arch/arm/vdso/vdsomunge.c:64:
> + (((unsigned short)(x) & (unsigned short)0xff00U) >> 8) ))
I have a pet hatred of too many parens. I also have a hatred of idiotic
casts. What about changing the above to one of:
(((x) & 0xff00) >> 8)
(((x) >> 8) & 0xff)
>
> ERROR: space prohibited before that close parenthesis ')'
> #53: FILE: arch/arm/vdso/vdsomunge.c:71:
> + (((unsigned int)(x) & (unsigned int)0xff000000UL) >> 24) ))
and one of:
(((x) & 0xff000000) >> 24)
(((x) >> 24) & 0xff)
?
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-15 16:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1443628457.git.hns@goldelico.com>
2015-09-30 15:56 ` [PATCH] ARM: fix vdsomunge depends " H. Nikolaus Schaller
2015-09-30 16:02 ` Ard Biesheuvel
2015-09-30 16:13 ` H. Nikolaus Schaller
2015-09-30 16:17 ` Ard Biesheuvel
2015-09-30 17:25 ` H. Nikolaus Schaller
2015-09-30 17:37 ` Nathan Lynch
2015-09-30 17:47 ` H. Nikolaus Schaller
2015-09-30 18:17 ` Nathan Lynch
2015-09-30 19:08 ` H. Nikolaus Schaller
2015-10-03 20:46 ` [PATCH v2] ARM: fix vdsomunge not to depend " H. Nikolaus Schaller
2015-10-14 12:47 ` H. Nikolaus Schaller
2015-10-14 14:16 ` Nathan Lynch
2015-10-15 5:52 ` H. Nikolaus Schaller
2015-10-15 16:37 ` Russell King - ARM Linux [this message]
2015-10-15 16:52 ` H. Nikolaus Schaller
2015-10-15 17:07 ` Nathan Lynch
2015-10-15 17:16 ` H. Nikolaus Schaller
2015-10-15 17:23 ` Nathan Lynch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015163712.GD32532@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=hns@goldelico.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=nathan_lynch@mentor.com \
--cc=szabolcs.nagy@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®